docs: improve docstrings for as_scalar() and as_table() #11613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
requested changes
Sep 29, 2025
|
@cpcloud Great suggestions, I accepted them, thanks! |
NickCrews
force-pushed
the
docs-as_scalar-as_table
branch
from
77ce709 to
0809105
Compare
NickCrews
force-pushed
the
docs-as_scalar-as_table
branch
from
0809105 to
cedbc6b
Compare
|
The two fixup commits I had to add here (because I thought we errored when doing bogus comparisons, but we don't actually error) to adjust the docstrings inspired me to write #11697 But that is a separate PR. |
NickCrews
commented
Oct 17, 2025
| >>> t.filter(t.island == heavy_gentoo.island) # quartodoc: +EXPECTED_FAILURE | ||
| Traceback (most recent call last): | ||
| ... | ||
| _duckdb.BinderException: Binder Error: Referenced table "t1" not found! |
There was a problem hiding this comment.
Currenty this errors at execution time. Is it possible for us to make this instead error at Expression construction time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make these more beginner friendly. "Scalar subquery" is very overwhelming for someone coming from pandas, and I think should be treated as an implementation detail.
I tried to add more examples, to actually show WHY you would want to use this.