Repository navigation
ci: fix Rust 1.100 breakage (clippy lints, pin toolchain to 1.99.1) - #1593
Conversation
Stable Rust 1.100 flags these clones as redundant, which fails `cargo clippy -- -D warnings` in CI for every PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
📊 Proxy Throughput ResultsShadowsocks
Trojan
VMess
VLESS
SOCKS5
AnyTLS
Hysteria2
TUIC
ShadowQUIC
SSH
Netem Tests (50 ms delay, 1% packet loss)Shadowsocks
Trojan
Hysteria2
ShadowQUIC
Ran 33 variant(s) in parallel; each direction transfers the full payload. 🖥️ Test Environment
📎 View full workflow run and download artifacts Full test logDownload the |
Rust 1.100's new cargo build-dir layout passes one `-L` per dependency to rustc. Under sccache on Windows the command line for tor-keymgr grows to ~35K characters (263 `-L` entries), over the 32K CreateProcess limit, failing with "The filename or extension is too long (os error 206)". Cargo falls back to an argfile when it spawns rustc directly, but not through the sccache wrapper. rust-toolchain.toml overrides the toolchain installed by the build workflow, so the pin goes there as well as in ci.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
CI picked up stable Rust 1.100.0 (2026-11-09), which broke the Build jobs on every PR (e.g. #1591, #1592) independent of their changes:
clash-lib, failing-D warnings. Removed them (viacargo clippy --fix), plus a leftover no-oplet dispatcher = dispatcher;in the mixed inbound.-Lper dependency to rustc. Under sccache the rustc command line fortor-keymgrreaches ~35K characters (263-Lentries), over the Windows 32K limit, failing withThe filename or extension is too long. (os error 206). Cargo falls back to an argfile when it spawns rustc itself, but not through the sccache wrapper. Pinned the toolchain to 1.99.1 inrust-toolchain.toml(which overrides the toolchain the build workflow installs) and inci.yml. Move back tostableonce sccache / the build workflow handles this.Test plan
cargo clippy -p clash-lib --all-targets -- -D warningson both 1.100.0 and 1.99.1 (with tuic, shadowsocks, ssh, shadowquic, wireguard, tun, redir, tproxy, onion, tailscale, telemetry)cargo clippy -p clash-rs -F standard,aws-lc-rs,onion --all-targets -- -D warningson both toolchainscargo +nightly fmt --all -- --check🤖 Generated with Claude Code
Summary by CodeRabbit