Skip to content

Added rules for enforcing abstract/interface/trait naming convention #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 4.6
Choose a base branch
from
Open

Added rules for enforcing abstract/interface/trait naming convention #5

wants to merge 3 commits into from

Conversation

@ViniTou
Copy link

@ViniTou ViniTou commented Oct 21, 2025 •
edited
Loading

🎫 Issue IBX-XXXXX

Description:

For admin-ui 4.6

 1185/1185 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------- 
  Line   src/contracts/Component/Renderable.php                 
 ------ ------------------------------------------------------- 
  17     Interface "Renderable" should have "Interface" suffix  
         at src/contracts/Component/Renderable.php:17           
 ------ ------------------------------------------------------- 

 ------ ----------------------------------------------------------- 
  Line   src/contracts/Controller/Controller.php                    
 ------ ----------------------------------------------------------- 
  14     Abstract class "Controller" should have "Abstract" prefix  
         at src/contracts/Controller/Controller.php:14              
 ------ ----------------------------------------------------------- 

 ------ ----------------------------------------------------- 
  Line   src/contracts/UniversalDiscovery/Provider.php        
 ------ ----------------------------------------------------- 
  14     Interface "Provider" should have "Interface" suffix  
         at src/contracts/UniversalDiscovery/Provider.php:14  
 ------ ----------------------------------------------------- 

 ------ ------------------------------------------------------------------- 
  Line   src/lib/Behat/Component/Fields/FieldTypeComponent.php              
 ------ ------------------------------------------------------------------- 
  16     Abstract class "FieldTypeComponent" should have "Abstract" prefix  
         at src/lib/Behat/Component/Fields/FieldTypeComponent.php:16        
 ------ ------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------- 
  Line   src/lib/Behat/Component/Fields/NonEditableField.php              
 ------ ----------------------------------------------------------------- 
  15     Abstract class "NonEditableField" should have "Abstract" prefix  
         at src/lib/Behat/Component/Fields/NonEditableField.php:15        
 ------ ----------------------------------------------------------------- 

 ------ ------------------------------------------------------------- 
  Line   src/lib/Form/Data/NewnessCheckable.php                       
 ------ ------------------------------------------------------------- 
  11     Interface "NewnessCheckable" should have "Interface" suffix  
         at src/lib/Form/Data/NewnessCheckable.php:11                 
 ------ ------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/lib/Form/Data/NewnessChecker.php               
 ------ --------------------------------------------------- 
  14     Trait "NewnessChecker" should have "Trait" suffix  
         at src/lib/Form/Data/NewnessChecker.php:14         
 ------ --------------------------------------------------- 

 ------ -------------------------------------------------------------------------------- 
  Line   src/lib/Form/TrashLocationOptionProvider/TrashLocationOptionProvider.php        
 ------ -------------------------------------------------------------------------------- 
  14     Interface "TrashLocationOptionProvider" should have "Interface" suffix          
         at src/lib/Form/TrashLocationOptionProvider/TrashLocationOptionProvider.php:14  
 ------ -------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------- 
  Line   src/lib/Form/Type/ChoiceList/Loader/BaseChoiceLoader.php         
 ------ ----------------------------------------------------------------- 
  14     Abstract class "BaseChoiceLoader" should have "Abstract" prefix  
         at src/lib/Form/Type/ChoiceList/Loader/BaseChoiceLoader.php:14   
 ------ ----------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------- 
  Line   src/lib/Limitation/Mapper/MultipleSelectionBasedMapper.php                   
 ------ ----------------------------------------------------------------------------- 
  19     Abstract class "MultipleSelectionBasedMapper" should have "Abstract" prefix  
         at src/lib/Limitation/Mapper/MultipleSelectionBasedMapper.php:19             
 ------ ----------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------- 
  Line   src/lib/QueryType/LocationSubtreeQueryType.php                           
 ------ ------------------------------------------------------------------------- 
  18     Abstract class "LocationSubtreeQueryType" should have "Abstract" prefix  
         at src/lib/QueryType/LocationSubtreeQueryType.php:18                     
 ------ ------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------- 
  Line   src/lib/QueryType/SubtreeQueryType.php                           
 ------ ----------------------------------------------------------------- 
  17     Abstract class "SubtreeQueryType" should have "Abstract" prefix  
         at src/lib/QueryType/SubtreeQueryType.php:17                     
 ------ ----------------------------------------------------------------- 

 ------ ----------------------------------------------------------------- 
  Line   src/lib/Specification/ContentSpecification.php                   
 ------ ----------------------------------------------------------------- 
  12     Interface "ContentSpecification" should have "Interface" suffix  
         at src/lib/Specification/ContentSpecification.php:12             
 ------ ----------------------------------------------------------------- 

 ------ -------------------------------------------------------------- 
  Line   src/lib/Specification/UserSpecification.php                   
 ------ -------------------------------------------------------------- 
  10     Interface "UserSpecification" should have "Interface" suffix  
         at src/lib/Specification/UserSpecification.php:10             
 ------ -------------------------------------------------------------- 

 ------ ------------------------------------------------------------- 
  Line   src/lib/UI/Service/IconResolver.php                          
 ------ ------------------------------------------------------------- 
  14     Abstract class "IconResolver" should have "Abstract" prefix  
         at src/lib/UI/Service/IconResolver.php:14                    
 ------ ------------------------------------------------------------- 

 ------ ------------------------------------------------------------------- 
  Line   src/lib/Validator/Constraints/FieldTypeValidator.php               
 ------ ------------------------------------------------------------------- 
  18     Abstract class "FieldTypeValidator" should have "Abstract" prefix  
         at src/lib/Validator/Constraints/FieldTypeValidator.php:18         
 ------ ------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------- 
  Line   tests/integration/REST/BaseAdminUiRestWebTestCase.php                      
 ------ --------------------------------------------------------------------------- 
  25     Abstract class "BaseAdminUiRestWebTestCase" should have "Abstract" prefix  
         at tests/integration/REST/BaseAdminUiRestWebTestCase.php:25                
 ------ --------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------- 
  Line   tests/lib/Menu/Action/BaseActionMenuBuilderTest.php                       
 ------ -------------------------------------------------------------------------- 
  30     Abstract class "BaseActionMenuBuilderTest" should have "Abstract" prefix  
         at tests/lib/Menu/Action/BaseActionMenuBuilderTest.php:30                 
 ------ -------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 18 errors

For QA:

Documentation:

@ViniTou ViniTou force-pushed the enforce-naming-convention branch from ebcecc1 to 4f25a02 Compare October 21, 2025 11:32
@ViniTou ViniTou requested a review from a team October 21, 2025 12:54
@ViniTou ViniTou mentioned this pull request Oct 21, 2025
Closed
@konradoboza konradoboza requested a review from a team October 22, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barw4 barw4 barw4 approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tbialcz tbialcz tbialcz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ViniTou @barw4 @konradoboza @tbialcz