Added rule for enforcing either interface or abstract class as dependency #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE:
This needs to be somehow improved - no idea how at this moment tho. For admin-ui 4.6 it reported exactly 900 errors. There are multiple instance from symfony - like
\Symfony\Component\HttpFoundation\Requestobject and from our side, like for exampleIbexa\Contracts\Core\Repository\Values\Content\ContentInfo.I guess we would have to narrow those checks to only our namespace (and make it configurable) and skip ValueObjects (and some configurable namespace per repo) from checks but this now seems like a lot of configuration for not that big gain.
Other way is to run it only on CodeReviews as comment, which should be doable and is a thing to consider.
For QA:
Documentation: