Skip to content

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Sep 22, 2025

As reported on Slack.

Things done:

  1. Removed deprecated usage of Ibexa\AdminUi\Component\TwigComponent, replaced by TemplateComponent: https://github.com/ibexa/admin-ui/blob/main/src/bundle/Resources/config/services/components.yaml#L44-L49
  2. Updated security.yaml config according to the contents of https://github.com/ibexa/commerce-skeleton/blob/v5.0.2/config/packages/security.yaml#L116C1-L117C42
  3. Adjusted wording around Guard/Custom authenticators (and updated link to https://symfony.com/doc/current/security/custom_authenticator.html)

Copy link

Preview of modified files

Preview of modified Markdown:

Copy link

code_samples/ change report

Before (on target branch)After (in current PR)

code_samples/user_management/oauth_google/config/custom_services.yaml

docs/users/oauth_client.md@97:``` yaml
docs/users/oauth_client.md@98:[[= include_file('code_samples/user_management/oauth_google/config/custom_services.yaml', 0, 6) =]]
docs/users/oauth_client.md@99:```

001⫶services:
002⫶ #…
003⫶
004⫶ App\OAuth\GoogleResourceOwnerMapper:
005⫶ tags:
006⫶ - { name: ibexa.oauth2_client.resource_owner_mapper, identifier: google }

docs/users/oauth_client.md@115:``` yaml
docs/users/oauth_client.md@116:services:
docs/users/oauth_client.md@117: #…
docs/users/oauth_client.md@118:
docs/users/oauth_client.md@119:[[= include_file('code_samples/user_management/oauth_google/config/custom_services.yaml', 7, 13) =]]
docs/users/oauth_client.md@120:```

001⫶services:
002⫶ #…
003⫶
004⫶ app.components.oauth2_login:

code_samples/user_management/oauth_google/config/custom_services.yaml

docs/users/oauth_client.md@97:``` yaml
docs/users/oauth_client.md@98:[[= include_file('code_samples/user_management/oauth_google/config/custom_services.yaml', 0, 6) =]]
docs/users/oauth_client.md@99:```

001⫶services:
002⫶ #…
003⫶
004⫶ App\OAuth\GoogleResourceOwnerMapper:
005⫶ tags:
006⫶ - { name: ibexa.oauth2_client.resource_owner_mapper, identifier: google }

docs/users/oauth_client.md@115:``` yaml
docs/users/oauth_client.md@116:services:
docs/users/oauth_client.md@117: #…
docs/users/oauth_client.md@118:
docs/users/oauth_client.md@119:[[= include_file('code_samples/user_management/oauth_google/config/custom_services.yaml', 7, 13) =]]
docs/users/oauth_client.md@120:```

001⫶services:
002⫶ #…
003⫶
004⫶ app.components.oauth2_login:
005⫶        parent: Ibexa\AdminUi\Component\TwigComponent
005⫶        parent: Ibexa\TwigComponents\Component\TemplateComponent
006⫶        arguments:
007⫶ $template: '@@ibexadesign/account/login/oauth2_login.html.twig'
008⫶ tags:
009⫶ - { name: ibexa.twig.component, group: admin-ui-login-form-after }


code_samples/user_management/oauth_google/config/packages/security.yaml

docs/users/oauth_client.md@49:``` yaml
docs/users/oauth_client.md@50:[[= include_file('code_samples/user_management/oauth_google/config/packages/security.yaml') =]]
docs/users/oauth_client.md@51:```

001⫶security:
002⫶ #…
003⫶
004⫶ firewalls:
005⫶ #…
006⫶
007⫶ # Uncomment ibexa_oauth2_connect, ibexa_oauth2_front rules and comment ibexa_front firewall
008⫶ # to enable OAuth2 authentication
009⫶
010⫶ ibexa_oauth2_connect:
011⫶ pattern: /oauth2/connect/*
012⫶ security: false
013⫶
014⫶ ibexa_oauth2_front:
015⫶ pattern: ^/
006⫶        arguments:
007⫶ $template: '@@ibexadesign/account/login/oauth2_login.html.twig'
008⫶ tags:
009⫶ - { name: ibexa.twig.component, group: admin-ui-login-form-after }


code_samples/user_management/oauth_google/config/packages/security.yaml

docs/users/oauth_client.md@49:``` yaml
docs/users/oauth_client.md@50:[[= include_file('code_samples/user_management/oauth_google/config/packages/security.yaml') =]]
docs/users/oauth_client.md@51:```

001⫶security:
002⫶ #…
003⫶
004⫶ firewalls:
005⫶ #…
006⫶
007⫶ # Uncomment ibexa_oauth2_connect, ibexa_oauth2_front rules and comment ibexa_front firewall
008⫶ # to enable OAuth2 authentication
009⫶
010⫶ ibexa_oauth2_connect:
011⫶ pattern: /oauth2/connect/*
012⫶ security: false
013⫶
014⫶ ibexa_oauth2_front:
015⫶ pattern: ^/
016⫶            user_checker: Ibexa\Core\MVC\Symfony\Security\UserChecker
017⫶ anonymous: ~
018⫶ ibexa_rest_session: ~
019⫶ guard:
020⫶ authenticators:
021⫶ - Ibexa\Bundle\OAuth2Client\Security\Authenticator\OAuth2Authenticator
022⫶ - Ibexa\PageBuilder\Security\EditorialMode\TokenAuthenticator
023⫶ entry_point: Ibexa\Bundle\OAuth2Client\Security\Authenticator\OAuth2Authenticator
024⫶ form_login:
025⫶ require_previous_session: false
026⫶ csrf_token_generator: security.csrf.token_manager
027⫶ logout: ~
028⫶
029⫶ #ibexa_front:
030⫶ # pattern: ^/
031⫶ # user_checker: Ibexa\Core\MVC\Symfony\Security\UserChecker
032⫶ # anonymous: ~
033⫶ # ibexa_rest_session: ~
034⫶ # form_login:
035⫶ # require_previous_session: false
036⫶ # csrf_token_generator: security.csrf.token_manager
037⫶ # guard:
038⫶ # authenticator: 'Ibexa\PageBuilder\Security\EditorialMode\TokenAuthenticator'
039⫶ # logout: ~
016⫶            provider: ibexa
017⫶ user_checker: Ibexa\Core\MVC\Symfony\Security\UserChecker
018⫶ custom_authenticators:
019⫶ - Ibexa\Bundle\OAuth2Client\Security\Authenticator\OAuth2Authenticator
020⫶ - Ibexa\PageBuilder\Security\EditorialMode\FragmentAuthenticator
021⫶ entry_point: Ibexa\Bundle\OAuth2Client\Security\Authenticator\OAuth2Authenticator
022⫶ context: ibexa
023⫶ form_login:
024⫶ enable_csrf: true
025⫶ logout: ~
026⫶
027⫶ # ibexa_front:
028⫶ # pattern: ^/
029⫶ # provider: ibexa
030⫶ # user_checker: Ibexa\Core\MVC\Symfony\Security\UserChecker
031⫶ # context: ibexa
032⫶ # form_login:
033⫶ # enable_csrf: true
034⫶ # login_path: login
035⫶ # check_path: login_check
036⫶ # custom_authenticators:
037⫶ # - Ibexa\PageBuilder\Security\EditorialMode\FragmentAuthenticator
038⫶ # entry_point: form_login
039⫶ # logout:
040⫶ # path: logout


Download colorized diff

@mnocon mnocon requested a review from a team September 22, 2025 14:00
@ezrobot ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team September 22, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants