Unified pills and headers across Documentation #2705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julitafalcondusza
approved these changes
Apr 17, 2025
Comment on lines
+33
to
+35
| &--inline { | ||
| margin-left: 10px; | ||
| } |
There was a problem hiding this comment.
Suggested change
| &--inline { | |
| margin-left: 10px; | |
| } | |
| &--inline { | |
| line-height: 18px; | |
| &:first-child { | |
| margin-left: 10px; | |
| } | |
| } |
There was a problem hiding this comment.
There is also some font-weight difference between https://ez-systems-developer-documentation--2705.com.readthedocs.build/en/2705/content_management/data_migration/importing_data/#segments and https://ez-systems-developer-documentation--2705.com.readthedocs.build/en/2705/ibexa_engage/ibexa_engage/ so maybe it should be ensured elsewhere. Maybe on pill class itself.
adriendupuis
requested changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target: master, 4.6
Things done:
Examples:
Also the current doc had a bug where the inline pill was displayed slightly below the text:
(see https://doc.ibexa.co/en/latest/update_and_migration/from_4.5/update_from_4.5/#dashboard-migration )
This is now fixed.