-
Notifications
You must be signed in to change notification settings - Fork 0
IBX-7899: Chip component #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new Chip component to the design system, implementing a removable tag-like UI element with various states (default, disabled, error) and optional close functionality.
Key Changes:
- New Chip React component with TypeScript types and styling
- Support for disabled, error states, and optional close button
- Storybook stories for documentation and visual testing with interaction tests
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/components/Chip/index.ts | Exports Chip component and types |
| packages/components/src/components/Chip/Chip.types.ts | Defines TypeScript interface for Chip props |
| packages/components/src/components/Chip/Chip.tsx | Implements Chip component logic and structure |
| packages/components/src/components/Chip/Chip.test.stories.tsx | Provides automated interaction tests for enabled/disabled states |
| packages/components/src/components/Chip/Chip.stories.tsx | Creates visual documentation stories for Storybook |
| packages/assets/src/scss/styles.scss | Imports chip styles into main stylesheet |
| packages/assets/src/scss/_chips.scss | Defines chip component styling with states and animations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Related PRs:
Description:
For QA:
Documentation: