Improved check if content is not empty #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We cannot move the “has content” check for the content block into the PHP side of a Symfony UX Twig Component, because the component class has no access to the rendered output of Twig blocks/slots. Blocks are resolved only during template rendering, so from PHP, you cannot reliably know if the content slot is empty or not.
We will keep the check in Twig, but avoid repeated block('content') calls by buffering the block once into a variable.
This way _content can be reused wherever needed, and has_content gives a clean boolean to control conditional rendering. If further centralization is desired, a small Twig filter/test or a helper method can process _content, but the capture of the block itself must remain in Twig.
For QA:
Documentation: