Merged branch '4.6' #684
Merged branch '4.6' #684
Conversation
For more details see #686 Key changes: * [DI] Dropped unknown NameSchema services
alongosz
force-pushed
the
fix-phpdoc-ezpublish-system-site-access
branch
from
285b7e4 to
b864345
Compare
alongosz
changed the title
|
| * @param array $config Complete parsed semantic configuration | ||
| * @param ContextualizerInterface $contextualizer | ||
| * | ||
| * @return mixed |
There was a problem hiding this comment.
Note
The return type was always void. Neither implementation is returning anything, nor the result is used anywhere. However this is an SPI, so adding here : void would cause a BC break. Added to PHPStan baseline.
There was a problem hiding this comment.
You could add void as declared phpdoc type to ensure this is detected in places it is used.
That way we could start considering this as a "deprecation".
There was a problem hiding this comment.
You could add
voidas declared phpdoc type to ensure this is detected in places it is used.That way we could start considering this as a "deprecation".
@Steveb-p I already tried that yesterday. It conflicts with phpdoc_no_empty_return PHP CS Fixer rule (gets auto-removed by fix-cs)
alongosz
requested review from
Steveb-p,
ViniTou,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
5 participants
Caution
Fast-forward merge (contains 4.6 tree merge commit)
Related PRs:
Description:
This PR:
ezpublishsite access semantic config references\Ibexa\Bundle\Core\DependencyInjection\Configuration\ParserInterface::addSemanticConfigand\Ibexa\Bundle\Core\DependencyInjection\Configuration\FieldTypeParserInterface::addFieldTypeSemanticConfigand removed redundant PHPDoc blocks.NodeBuilder,TreeBuilder, andArrayNodeDefinitionTParent templates introduced in Symfony 7.4