-
Notifications
You must be signed in to change notification settings - Fork 17
IBX-10494: Included Postgres 18 on CI #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
micszo
wants to merge
5
commits into
4.6
Choose a base branch
from
ibx-10494
base: 4.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7135507
IBX-10494: Included Postgres 18 on CI
micszo e1a15c1
[CI] Align secrets for browser tests
micszo f925665
Fixed inconsistent test
Steveb-p 4501d4d
Postgres 14 & 18 setup
micszo 42fbc99
Revert "[CI] Align secrets for browser tests"
micszo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -268,7 +268,7 @@ public function getCriteriaForInitialData(): iterable | |
yield 'Sibling IN 2, 1]' => new Criterion\Sibling(2, 1); | ||
yield 'Subtree=/1/2/' => new Criterion\Subtree('/1/2/'); | ||
yield '[email protected]' => new Criterion\UserEmail('[email protected]'); | ||
yield 'UserEmail=admin@*' => new Criterion\UserEmail('*@link.invalid', Criterion\Operator::LIKE); | ||
yield 'UserEmail=admin@*' => new Criterion\UserEmail('admin@*', Criterion\Operator::LIKE); | ||
yield 'UserId=14' => new Criterion\UserId(14); | ||
yield 'UserLogin=admin' => new Criterion\UserLogin('admin'); | ||
yield 'UserLogin=a*' => new Criterion\UserLogin('a*', Criterion\Operator::LIKE); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- uses: actions/create-github-app-token@v2 id: generate_token with: app-id: ${{ secrets.AUTOMATION_CLIENT_ID }} private-key: ${{ secrets.AUTOMATION_CLIENT_SECRET }} owner: ${{ github.repository_owner }}
is not needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially there was de8f501 but it left the PR after rebase. Other fixes to setup were not needed.