Extracted redundant TextLine and ISBN SearchField into a common base #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
konradoboza
approved these changes
Aug 27, 2024
Steveb-p
approved these changes
Aug 27, 2024
ciastektk
approved these changes
Aug 27, 2024
|
Regressions & CI all green, merging this one as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR addresses code redundancy between ISBN and TextLine SearchField types. Code for these classes was identical. The reason for that is that both TextLine and ISBN are single text lines, indexed identically.
For QA:
Regression build should be enough (ibexa/commerce#1008).