Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-9723: Relative URLs in ezurl field no longer works #1499

Merged
merged 2 commits into from
Mar 19, 2025
Merged

IBX-9723: Relative URLs in ezurl field no longer works #1499

merged 2 commits into from
Mar 19, 2025

Conversation

OstafinL
Copy link
Contributor

@OstafinL OstafinL commented Mar 14, 2025 •
edited
Loading

🎫 Issue IBX-9723

Description:

I changed the url validation to a regular expression checking if the string starts with:

  • http://
  • https://
  • ftp://
  • ftps://
  • sftp://
  • www.
  • /
  • ezlocation://
  • domain
  • sub.domain

And after this has at least one character. The previously solution with canParse returns true for e.g. http:a

For QA:

Documentation:

@OstafinL OstafinL added Bug Something isn't working Ready for review labels Mar 14, 2025
@OstafinL OstafinL requested a review from a team March 14, 2025 13:10
@tischsoic tischsoic changed the title IBX-9723: Relative URLs in ezurl field no longer wors IBX-9723: Relative URLs in ezurl field no longer works Mar 17, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OstafinL OstafinL requested review from glye and dew326 March 17, 2025 10:38
glye
glye approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In cases like this I always have the creeping freeling that we may have forgotten something, but... 🤞

This was referenced Mar 19, 2025
Closed
Closed
@juskora
Copy link
Contributor

juskora commented Mar 19, 2025

QA Approved on Ibexa DXP Commerce 4.6-dev and OSS.

@dew326 dew326 merged commit 3fbaee9 into 4.6 Mar 19, 2025
30 checks passed
@dew326 dew326 deleted the IBX-9723-relative-uRLs-in-ezurl-field-no-longer-wors branch March 19, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glye glye glye approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@juskora juskora juskora approved these changes

@RopRaptor RopRaptor RopRaptor approved these changes

@albozek albozek albozek approved these changes

Assignees

@mikadamczyk mikadamczyk

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@OstafinL @juskora @glye @GrabowskiM @dew326 @RopRaptor @albozek @mikadamczyk @ciastektk @ViniTou