fix: --swarm flag silently ignored in /review-pr and /fix-ci#15
Merged
Conversation
The LLM was skipping advisory "Mode Selection" and executing Standard Workflow regardless of --swarm flag. Replaced with imperative "CRITICAL: Route Selection" gate in review-pr and strengthened "Parse Flags First" with explicit SWARM_MODE variable and back-reference in ci-fix-loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/review-pr: Replaced advisory "Argument Parsing" + "Mode Selection" with imperative "CRITICAL: Route Selection" gate/fix-ci(ci-fix-loop skill): Strengthened "CRITICAL: Parse Flags First" with explicitSWARM_MODE=truevariable and back-reference in Step 2.5 condition checkRoot Cause
The LLM read the command prompt top-to-bottom and started executing the first actionable section (Standard Workflow) before processing the routing gate. The weak advisory language ("If user requested swarm mode, execute Swarm Workflow below") wasn't treated as a hard stop.
Test plan
/review-pr --swarm 123triggers agent team creation and spawns 4 reviewer teammates/review-pr 123runs standard sequential review/fix-ci --swarmwith 2+ file errors triggers team-based parallel fixing/fix-ci --loopruns standard serial fix loop