enhancement: #10 - Fix create-pr leaking Commits and Test Plan sections#11
Merged
enhancement: #10 - Fix create-pr leaking Commits and Test Plan sections#11
Conversation
Root cause: git log step primes model with commit data before body generation, and Testing Notes section is too permissive. Also phase-submit.md contradicts create-pr exclusion rules. Reviewed by GPT-5.2-Codex and Gemini 3 Pro.
Remove git log step that primed the model with commit data before body generation. Rewrite Testing Notes to default-omit with explicit triggers for manual reviewer actions and performed verification reporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/github:create-prcommand intermittently generates PR descriptions that include a "Commits" section and a generic "Test plan" section despite explicit exclusion rules. Root cause: thegit logstep primes the model with commit data before body generation, and the Testing Notes framing is too permissive.Review Focus
Files to review (in order):
commands/create-pr.md— Core fix: removedgit logstep from Run section (was step 5), rewrote Testing Notes to default-omit with two explicit triggersCHANGELOG.md— v1.4.1 entry documenting the fixpackage.json/.claude-plugin/plugin.json— Version bump to 1.4.1Key decisions:
git logentirely rather than moving it post-creation — the model doesn't need commit history when it has issue + plan + diffNote: A companion fix was committed to
workflows-plugin(phase-submit.md) removing the contradicting "Test plan" instruction — that change lives in the workflows-plugin repo.Plan & Design
See
plans/fix-create-pr-leaking-sections.mdfor full implementation design and validation criteria.Related research:
research/research-sdlc-submit-pr-description.mdresearch/pr-description-best-practices.mdCloses #10