-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecated 3.x APIs in core-frontend except rpcInterface, scheduleScriptReference and getThumbnail #7591
Conversation
…Z/deprecate-core-frontend
@pmconne For |
Reserve it for a separate PR and file an issue where we can discuss. |
This pull request is now in conflicts. Could you fix it @williamzqr1? 🙏 |
…Z/deprecate-core-frontend
Separate issue for rpcInterfaces: https://github.com/iTwin/itwinjs-backlog/issues/1374 |
core-geometry.api.md changes are already on main due to #7588, so when you update branch, those should disappear. |
…Z/deprecate-core-frontend
…/itwinjs-core into WZ/deprecate-core-frontend
I see that multiple files have only whitespace changes. I figure that this is because you edited those files initially when attempting make all changes in this branch but reverted them to break them out into separate PRs. Ideally you would want to revert all changes that is only whitepsace changes too but I don't think that should hold up this PR so imo fine for now. Just something to look out for next time :) |
PR for removing the deprecated 3.x APIs in core-frontend. Most of the APIs that are deprecated in 3.x have been removed.
There are three of the APIs that have not been removed yet.
rpcInterface
: https://github.com/iTwin/itwinjs-backlog/issues/1374scheduleScriptReference
: https://github.com/iTwin/itwinjs-backlog/issues/1375getThumbnail
: https://github.com/iTwin/itwinjs-backlog/issues/1376I will create sub issues for them and link the issues in this PR.