Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated 3.x APIs in core-frontend except rpcInterface, scheduleScriptReference and getThumbnail #7591

Merged
merged 19 commits into from
Jan 27, 2025

Conversation

williamzqr1
Copy link
Contributor

@williamzqr1 williamzqr1 commented Jan 22, 2025

PR for removing the deprecated 3.x APIs in core-frontend. Most of the APIs that are deprecated in 3.x have been removed.
There are three of the APIs that have not been removed yet.

  1. rpcInterface: https://github.com/iTwin/itwinjs-backlog/issues/1374
  2. scheduleScriptReference: https://github.com/iTwin/itwinjs-backlog/issues/1375
  3. getThumbnail: https://github.com/iTwin/itwinjs-backlog/issues/1376

I will create sub issues for them and link the issues in this PR.

@williamzqr1 williamzqr1 marked this pull request as draft January 22, 2025 22:23
@pmconne pmconne changed the title Removed deprecated core-frontend packages Removed deprecated core-frontend APIs Jan 23, 2025
@williamzqr1
Copy link
Contributor Author

williamzqr1 commented Jan 23, 2025

@pmconne
For scheduleScriptReference, I was confused by the usage of sourceId from scheduleScriptReference. Most of the places that used sourceId cannot be simply replaced by scheduleScript. And removing the usage of sourceId would affect the functionality of the code. For example in here

For rpcInterface, I will add a separate issue for that one

@pmconne
Copy link
Member

pmconne commented Jan 24, 2025

For scheduleScriptReference

Reserve it for a separate PR and file an issue where we can discuss.

@williamzqr1 williamzqr1 marked this pull request as ready for review January 24, 2025 21:13
@williamzqr1 williamzqr1 requested a review from a team as a code owner January 24, 2025 21:13
Copy link
Contributor

mergify bot commented Jan 24, 2025

This pull request is now in conflicts. Could you fix it @williamzqr1? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@williamzqr1
Copy link
Contributor Author

Separate issue for rpcInterfaces: https://github.com/iTwin/itwinjs-backlog/issues/1374

@dassaf4
Copy link
Member

dassaf4 commented Jan 25, 2025

core-geometry.api.md changes are already on main due to #7588, so when you update branch, those should disappear.

@aruniverse aruniverse enabled auto-merge (squash) January 27, 2025 14:29
@anmolshres98
Copy link
Contributor

I see that multiple files have only whitespace changes. I figure that this is because you edited those files initially when attempting make all changes in this branch but reverted them to break them out into separate PRs. Ideally you would want to revert all changes that is only whitepsace changes too but I don't think that should hold up this PR so imo fine for now. Just something to look out for next time :)

@aruniverse aruniverse merged commit d9e81f3 into master Jan 27, 2025
16 checks passed
@aruniverse aruniverse deleted the WZ/deprecate-core-frontend branch January 27, 2025 17:14
@williamzqr1 williamzqr1 changed the title Removed deprecated core-frontend APIs Removed deprecated 3.x APIs in core-frontend Jan 27, 2025
@williamzqr1 williamzqr1 changed the title Removed deprecated 3.x APIs in core-frontend Removed deprecated 3.x APIs in core-frontend except rpcInterface, scheduleScriptReference and getThumbnail Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants