Fix GraphicRepresentation types according to latest Mesh Export API docs #7570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eringram
commented
Jan 21, 2025
There was a problem hiding this comment.
Looks good to me.
I will defer to @danieliborra and @arvindsvenkat for final approval, though.
Do we need to notify anyone of this change?
aruniverse
reviewed
Jan 22, 2025
extensions/frontend-tiles/src/GraphicsProvider/GraphicRepresentationProvider.ts
Outdated
Show resolved
Hide resolved
No, we were planning for it to go in 5.0. |
eringram
commented
Jan 23, 2025
extensions/frontend-tiles/src/GraphicsProvider/GraphicRepresentationProvider.ts
Outdated
Show resolved
Hide resolved
pmconne
reviewed
Jan 23, 2025
aruniverse
reviewed
Jan 24, 2025
common/changes/@itwin/frontend-tiles/eringram-graphicrepresentation-fix_2025-01-21-17-59.json
Outdated
Show resolved
Hide resolved
extensions/frontend-tiles/src/GraphicsProvider/GraphicRepresentationProvider.ts
Outdated
Show resolved
Hide resolved
…om/iTwin/itwinjs-core into eringram/graphicrepresentation-fix
extensions/frontend-tiles/src/test/GraphicsProvider/GraphicRepresentationProvider.test.ts
Outdated
Show resolved
Hide resolved
aruniverse
approved these changes
Jan 30, 2025
danieliborra
approved these changes
Jan 30, 2025
markschlosseratbentley
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
GraphicRepresentationFormattype andGraphicRepresentationStatusenum to reflect the latest Mesh Export Service docs. These are breaking changes to beta APIs intended to go into iTwin.js 5.0.