-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor V2 version selector so that its logic can be reused #124
Open
roluk
wants to merge
21
commits into
master
Choose a base branch
from
refactor-v2-selector
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebGerman
reviewed
Nov 26, 2024
...ges/changed-elements-react/src/widgets/comparisonJobWidget/VersionCompareSelectComponent.tsx
Outdated
Show resolved
Hide resolved
CalebGerman
reviewed
Nov 26, 2024
...ages/changed-elements-react/src/widgets/comparisonJobWidget/VersionCompareSelectDialogV2.tsx
Outdated
Show resolved
Hide resolved
CalebGerman
approved these changes
Nov 27, 2024
diegopinate
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git cannot produce a good diff of accumulated changes because I move the code and files around. I suggest going through each commit individually when doing a thorough review.
useNamedVersionLoading
hook so that we can reuse it with minimal impact to future code complexityThe code became easier to read, IMO. If you discover any unwanted behavior, I'll defer fixing it to another PR unless it's a regression.