Skip to content

fix(pptx): honor noFill text outlines in HTML preview #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
y4ho0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pptx): honor noFill text outlines in HTML preview #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/officecli/Handlers/Pptx/PowerPointHandler.HtmlPreview.Text.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,11 +1133,12 @@ private static void RenderRun(StringBuilder sb, Drawing.Run run, Dictionary<stri
// Run-level text outline (a:rPr/a:ln). PowerPoint strokes each glyph
// edge; Chromium renders this via -webkit-text-stroke. Width is the
// a:ln @w in EMU (12700 EMU = 1pt); convert to px (1pt = 4/3 px) so a
// 3pt outline reads as a ~4px stroke. Color comes from the a:ln's
// solidFill child (default black when absent). paint-order:stroke fill
// keeps the fill painted on top so the stroke hugs the glyph outside.
// 3pt outline reads as a ~4px stroke. An explicit noFill disables
// the stroke; otherwise color comes from solidFill (default black
// when absent). paint-order:stroke fill keeps the fill painted on
// top so the stroke hugs the glyph outside.
var runOutline = rp.GetFirstChild<Drawing.Outline>();
if (runOutline != null)
if (runOutline != null && runOutline.GetFirstChild<Drawing.NoFill>() == null)
{
double strokePx = runOutline.Width?.HasValue == true
? Units.EmuToPt(runOutline.Width.Value) * 4.0 / 3.0
Expand Down