fix(view): preserve native render failure diagnostics - #329
Open
y4ho0 wants to merge 1 commit into
Open
Conversation
y4ho0
marked this pull request as ready for review
August 20, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--render nativediagnostics--render autobehavior unchanged: native failures still fall back silently to HTMLWhy
When Office is installed and COM activation succeeds, a document-specific open failure such as
Invoke(Open) hr=0x80070570was swallowed by the native backend. The caller then reported that PowerPoint or Word was not installed, which sent users toward the wrong fix and hid the useful HRESULT.The native backends now surface worker-thread failures while preserving their original stack. Explicit native mode maps those failures to either
native_unavailableornative_render_failed; auto mode continues to catch them and use the existing HTML fallback.Validation
dotnet build src/officecli/officecli.csproj -c Release— succeeded with 0 errorsnative_unavailablenative_unavailablewith HRESULTInvoke(Open) hr=0x80070570→native_render_failedwith the original stage and HRESULTnative_render_failed--render autoretains its fallback behaviorCloses #326