fix(update): honor OFFICECLI_SKIP_UPDATE in MCP paths - #303
Open
xue-x-d wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OFFICECLI_SKIP_UPDATE=1insideUpdateChecker.CheckInBackground()__update-check__/RunRefresh()pathRoot cause
Program.csdispatchesmcp,mcp-serve, and the internal__update-check__command before the existing per-invocation
OFFICECLI_SKIP_UPDATEguard. TheMCP server then calls
CheckInBackground()at startup and every hour, so an MCPprocess could still stage and apply a self-update even when its parent explicitly
disabled updates.
Keeping the guard in
UpdateCheckermakes the environment variable an invariantfor every automatic-update entry point while preserving the default auto-update
behavior when the variable is unset.
Validation
Black-box reproduction with an isolated home and
autoUpdate=false:CheckInBackground()and writeslastSkillRefreshVersion.OFFICECLI_SKIP_UPDATE: the hashes still differ, confirmingthe normal update path remains enabled.
dotnet build src/officecli/officecli.csproj -c Release --no-restore --nologosucceeds (one pre-existing nullable warning in
ExcelHandler.SheetShift.cs).dotnet publish src/officecli/officecli.csproj -c Release -r win-x64succeeds and produces an x86-64 Windows PE executable.