Skip to content

Conversation

PierreJeanjacquot
Copy link
Member

NB: still have transient dep to @iexec/[email protected] v5 through @iexec/[email protected]

[email protected]
├── @iexec/[email protected]
└─┬ @iexec/[email protected]
  └── @iexec/[email protected]

Copy link

github-actions bot commented Oct 13, 2025

🐳 Hadolint Dockerfile Lint Results

Click to expand detailed results
Dockerfile:17 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>`

@PierreJeanjacquot
Copy link
Member Author

@zguesmi we cannot migrate to v6 because ENS-related methods have been removed from ABI while being still used on Bellecour

@zguesmi
Copy link
Member

zguesmi commented Oct 13, 2025

@zguesmi we cannot migrate to v6 because ENS-related methods have been removed from ABI while being still used on Bellecour

@PierreJeanjacquot could you please list the functions that are not available anymore? We tried to keep most of them but we might've missed some.

@PierreJeanjacquot
Copy link
Member Author

@zguesmi tests fail due to a stateMutability issue in the setName ABI.

    {
      "inputs": [
        {
          "internalType": "address",
          "name": "",
          "type": "address"
        },
        {
          "internalType": "string",
          "name": "",
          "type": "string"
        }
      ],
      "name": "setName",
      "outputs": [],
      "stateMutability": "view", // should be "nonpayable"
      "type": "function"
    }

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
43.0% Coverage on New Code (required ≥ 80%)
12.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants