feat(tests): add Localstack testing workflow #41
+218
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Le-Caignec
reviewed
May 20, 2025
Comment on lines
+69
to
+80
| sudo apt-get update | ||
| sudo apt-get install -y xxd | ||
| npm install -g . |
There was a problem hiding this comment.
what is the goal of those lines ?
There was a problem hiding this comment.
There was a problem hiding this comment.
yeah but it's not always needed if you check dataprotector-sdk for instance
https://github.com/iExecBlockchainComputing/dataprotector-sdk/blob/develop/packages/sdk/.drone.yml
There was a problem hiding this comment.
If is in var it's good for you ?
Comment on lines
+74
to
+87
| - name: SonarScanner | ||
| uses: SonarSource/[email protected] | ||
| env: | ||
| SONAR_TOKEN: ${{ inputs.sonar-token }} | ||
| SONAR_HOST_URL: ${{ inputs.sonar-host-url }} |
There was a problem hiding this comment.
Can you explain what SonarScanner is ? What it do ?
There was a problem hiding this comment.
Code quality tool related to iExec SDK too:
There was a problem hiding this comment.
@Le-Caignec Good for the explain ?
|
could you add optionnal step |
TartanLeGrand
force-pushed
the
feat/tests/add-localstack
branch
from
f8c881e to
fa2244b
Compare
… type for check types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new GitHub Actions workflow for running Localstack tests and adds a corresponding README file. The workflow is designed to streamline testing, linting, and code quality checks, including integration with SonarQube/SonarCloud for static analysis.
Additions to CI/CD workflows:
.github/workflows/localstack-tests.yml: Added a new reusable workflow named "Localstack Tests" that includes steps for setting up the environment, running tests, linting, checking code formatting, and performing static analysis with SonarQube/SonarCloud. It accepts inputs such as API keys, project IDs, and Node.js version.Documentation:
localstack-tests/README.md: Added a placeholder README file for the Localstack Tests workflow.