feat: Upgrade to Solidity v0.8.0 #287
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zguesmi
commented
Oct 14, 2025
Comment on lines
+41
to
+47
| /** | ||
| * @dev Added for retrocompatibility! | ||
| * | ||
| * @dev Returns the base URI set via {setBaseURI}. This will be | ||
| * automatically added as a prefix in {tokenURI} to each token's ID. | ||
| */ | ||
| function baseURI() public view returns (string memory) { |
There was a problem hiding this comment.
Not used outside of the PoCo project:
https://github.com/search?q=org%3AiExecBlockchainComputing+baseURI&type=code
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 84.85% 89.84% +4.99%
==========================================
Files 37 38 +1
Lines 1241 1201 -40
Branches 235 236 +1
==========================================
+ Hits 1053 1079 +26
+ Misses 188 122 -66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zguesmi
commented
Oct 14, 2025
| import {PocoStorageLib} from "../libs/PocoStorageLib.sol"; | ||
| import {FacetBase} from "./FacetBase.sol"; | ||
|
|
||
| // TODO uncomment and fix file |
zguesmi
commented
Oct 14, 2025
Comment on lines
+112
to
+114
| // try address(0)(_identity).isValidSignature(_hash, _signature) returns (bytes4 value) { | ||
| // return value == address(0)(address(0)).isValidSignature.selector; | ||
| // } catch (bytes memory /*lowLevelData*/) {} |
zguesmi
commented
Oct 14, 2025
Comment on lines
+128
to
+136
| // try IERC1271(_identity).isValidSignature(_predicat, _signature) returns (bytes4 value) { | ||
| // return value == IERC1271(address(0)).isValidSignature.selector; | ||
| // } catch (bytes memory /*lowLevelData*/) {} | ||
|
|
||
| // try IERC1654(_identity).isValidSignature(keccak256(_predicat), _signature) returns ( | ||
| // bytes4 value | ||
| // ) { | ||
| // return value == IERC1654(0).isValidSignature.selector; | ||
| // } catch (bytes memory /*lowLevelData*/) {} |
zguesmi
commented
Oct 14, 2025
| IexecConfigurationExtra, | ||
| IexecERC20, | ||
| IexecERC20Common, | ||
| IexecERC20, |
There was a problem hiding this comment.
To resolve compiler dependency linearisation issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
contracts/facets/IexecEscrowTokenSwapFacet.solhas been removed to minimize upgrade overhead. It shouldn't break any user interaction because the module was not deployed on Bellecour nor Arbitrum.Breaking changes
All modified tests are to be considered as breaking changes.
Next steps:
>=0.6.0to^0.8.0@openzeppelin/contracts (v3)@openzeppelin/contracts-v5to@openzeppelin/contractsiexec-solidityiexec-interfaces