Don't raise an error on QL spectra reshape emit warning instead #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 72.29% 72.23% -0.06%
==========================================
Files 78 78
Lines 8073 8085 +12
==========================================
+ Hits 5836 5840 +4
- Misses 2237 2245 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Looking at this again I'm not sure it won't just error at a later line ... |
samaloney
force-pushed
the
ql-spectra-warning
branch
3 times, most recently
from
9d42c13 to
8edda2a
Compare
* Create a custom execption * Change the level of log message for the custom exception
samaloney
force-pushed
the
ql-spectra-warning
branch
from
8edda2a to
02d7e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we get these error every day and may be missing real errors as in the end the QL spectra a created properly.
This PR attempts to disable the error to see will help until we can reproduce and fix the error (#421).