Skip to content

Dev/v1.1.0#41

Closed
RCMast3r wants to merge 98 commits into
masterfrom
dev/v1.1.0
Closed

Dev/v1.1.0#41
RCMast3r wants to merge 98 commits into
masterfrom
dev/v1.1.0

Conversation

@RCMast3r
Copy link
Copy Markdown
Contributor

@RCMast3r RCMast3r commented May 11, 2025

Comment thread config/config_test.json
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needed?

@@ -0,0 +1,15 @@
g{
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

auto cmd = simple_controller.step_controller(in);
auto res = std::get_if<core::TorqueControlOut>(&cmd.out);

ASSERT_NEAR(res->desired_torques_nm.FR, 4.48, 1.0);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make helper for this?

template <typename T>
float linear_approx(T x_val, T scale, T offset)
{
return ((static_cast<float>(x_val) * static_cast<float>(scale)) + (static_cast<float>(offset)));
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one of these should need to be static casted

#include <Utils.hpp>
namespace math
{
template <typename T>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just not make this generic if numbers are gonna be casted to floats anyway

@KrishKittur KrishKittur deleted the branch master November 5, 2025 04:51
@KrishKittur KrishKittur closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

seeming software restart issue with stopping logging through GRPC server

4 participants