Skip to content

fix: resolve all pnpm build TypeScript and runtime errors#2021

Open
plitzenberger wants to merge 8 commits intomainfrom
cursor/pnpm-build-errors-0d02
Open

fix: resolve all pnpm build TypeScript and runtime errors#2021
plitzenberger wants to merge 8 commits intomainfrom
cursor/pnpm-build-errors-0d02

Conversation

@plitzenberger
Copy link
Member

  • visible-spaces-list: convert null to undefined for useUserSpaceState spaceId
  • layout: remove unused @ts-expect-error directive
  • extract-revert-reason: add isHexData type guard and fix error.data typing
  • decoders: use Abi type for decodeFunctionData, fix ProposalTx
  • useProposalActions/useProposalDetails: fix readonly array and unknown assertions
  • get-proposal-created-event/get-space-created-event: add Log[] type for parseEventLogs
  • governance validation: add milestone undefined guard
  • space queries: convert null to undefined for DB record mapping
  • create-agreement-base-fields: use schemaCreateAgreementFiles for z.infer
  • Image avatarUrl: add typeof string guards for Next.js Image src prop
  • propose-contribution validation: add milestone undefined guard
  • button-profile: ensure isErrorUser returns boolean
  • delegate-voting-section: fix unknown error type for ReactNode
  • member-card/space-member-card: add string guard for memberAddress
  • date-picker: conditional render for single vs range Calendar mode
  • slider: handle undefined from newValue[0]
  • .env.template: add DEFAULT_DB_URL for build (storage-postgres invariant)

Co-authored-by: webguru-hypha webguru-hypha@users.noreply.github.com

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

Important

Review skipped

Too many files!

This PR contains 153 files, which is 3 over the limit of 150.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a0abb695-a147-456a-be5e-32becc0ccf22

📥 Commits

Reviewing files that changed from the base of the PR and between 7801d3c and 89fd265.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (153)
  • apps/hypha-migration/hypha-react-demo/package.json
  • apps/web/.env.template
  • apps/web/package.json
  • apps/web/src/app/[lang]/dho/[id]/@aside/[tab]/space-configuration/page.tsx
  • apps/web/src/app/[lang]/dho/[id]/@aside/agreements/create/change-entry-method/page.tsx
  • apps/web/src/app/[lang]/dho/[id]/@aside/agreements/create/propose-contribution/page.tsx
  • apps/web/src/app/[lang]/dho/[id]/@aside/agreements/proposal/[documentSlug]/page.tsx
  • apps/web/src/app/[lang]/dho/[id]/@aside/agreements/proposal/[documentSlug]/voters/page.tsx
  • apps/web/src/app/[lang]/dho/[id]/_components/select-settings-action.tsx
  • apps/web/src/app/[lang]/dho/[id]/_components/space-visualization.tsx
  • apps/web/src/app/[lang]/dho/[id]/_components/visible-spaces-list.tsx
  • apps/web/src/app/[lang]/dho/[id]/layout.tsx
  • apps/web/src/app/[lang]/my-spaces/@aside/create/page.tsx
  • apps/web/src/app/[lang]/profile/@aside/signup/page.tsx
  • apps/web/src/app/[lang]/profile/[personSlug]/@aside/edit/page.tsx
  • apps/web/src/app/[lang]/profile/[personSlug]/page.tsx
  • apps/web/src/app/[lang]/profile/page.tsx
  • apps/web/src/app/api/v1/people/[personSlug]/assets/route.ts
  • apps/web/src/app/api/v1/people/[personSlug]/transactions/route.ts
  • apps/web/src/app/api/v1/spaces/[spaceSlug]/assets-without-balances/route.ts
  • apps/web/src/app/api/v1/spaces/[spaceSlug]/assets/route.ts
  • apps/web/src/app/api/v1/spaces/[spaceSlug]/documents/route.ts
  • apps/web/src/app/api/v1/spaces/[spaceSlug]/members/route.ts
  • apps/web/src/app/api/v1/spaces/[spaceSlug]/organisation/route.ts
  • apps/web/src/app/api/v1/spaces/[spaceSlug]/transfers/route.ts
  • apps/web/src/app/api/v1/tokens/[token]/supply/route.ts
  • apps/web/src/hooks/use-space-documents.ts
  • apps/web/src/middleware.ts
  • eslint.config.mjs
  • packages/authentication/package.json
  • packages/cookie/package.json
  • packages/core/package.json
  • packages/core/src/assets/server/queries.ts
  • packages/core/src/common/server/extract-revert-reason.ts
  • packages/core/src/common/server/get-transfers-by-address.ts
  • packages/core/src/common/server/route-handlers/handler-with-middleware.ts
  • packages/core/src/common/server/route-handlers/types.ts
  • packages/core/src/common/server/web3-rpc/get-balance.ts
  • packages/core/src/common/server/web3-rpc/get-supply.ts
  • packages/core/src/common/server/web3-rpc/get-token-meta.ts
  • packages/core/src/common/web3/get-balance.ts
  • packages/core/src/common/web3/get-token-decimals.ts
  • packages/core/src/common/web3/get-token-meta.ts
  • packages/core/src/events/types.ts
  • packages/core/src/governance/client/hooks/decoders.ts
  • packages/core/src/governance/client/hooks/useAgreementFileUploads.ts
  • packages/core/src/governance/client/hooks/useChangeSpaceTransparencySettingsMutations.web3.rpc.ts
  • packages/core/src/governance/client/hooks/useCreateAgreementOrchestrator.ts
  • packages/core/src/governance/client/hooks/useIssueNewTokenOrchestrator.ts
  • packages/core/src/governance/client/hooks/useJoinSpaceProposalHandler.ts
  • packages/core/src/governance/client/hooks/useMembershipExitOrchestrator.ts
  • packages/core/src/governance/client/hooks/useProposalActions.ts
  • packages/core/src/governance/client/hooks/useProposalDetails.web3.rpc.ts
  • packages/core/src/governance/client/web3/get-proposal-created-event.ts
  • packages/core/src/governance/server/actions.ts
  • packages/core/src/governance/types.ts
  • packages/core/src/governance/validation.ts
  • packages/core/src/people/client/web3/useTransferTokensMutation.ts
  • packages/core/src/people/server/actions.ts
  • packages/core/src/space/client/hooks/useCreateSpaceOrchestrator.ts
  • packages/core/src/space/client/hooks/useDelegate.web3.rpc.ts
  • packages/core/src/space/client/hooks/useRemoveMember.web3.rpc.ts
  • packages/core/src/space/client/hooks/useSpaceDelegate.ts
  • packages/core/src/space/client/hooks/useUndelegate.web3.rpc.ts
  • packages/core/src/space/client/web3/dao-space-factory/get-space-created-event.ts
  • packages/core/src/space/server/actions.ts
  • packages/core/src/space/server/mutations.ts
  • packages/core/src/space/server/queries.ts
  • packages/epics/package.json
  • packages/epics/src/agreements/components/create-agreement-base-fields.tsx
  • packages/epics/src/agreements/plugins/components/common/member-with-number.tsx
  • packages/epics/src/agreements/plugins/components/common/quorum-and-unity-changer.tsx
  • packages/epics/src/agreements/plugins/components/common/recipient.tsx
  • packages/epics/src/agreements/plugins/components/common/space-to-space-membership-selector.tsx
  • packages/epics/src/agreements/plugins/components/common/token-payout-field.tsx
  • packages/epics/src/agreements/plugins/propose-contribution/validation.ts
  • packages/epics/src/agreements/plugins/space-to-space-membership/plugin.tsx
  • packages/epics/src/agreements/plugins/space-transparency-settings/plugin.tsx
  • packages/epics/src/governance/components/activate-spaces-form-space.tsx
  • packages/epics/src/governance/components/buy-hypha-tokens-form.tsx
  • packages/epics/src/governance/components/create-agreement-form.tsx
  • packages/epics/src/governance/components/create-deploy-funds-form.tsx
  • packages/epics/src/governance/components/create-pay-for-expenses-form.tsx
  • packages/epics/src/governance/components/create-proposal-change-entry-method-form.tsx
  • packages/epics/src/governance/components/create-proposal-change-space-transparency-settings-form.tsx
  • packages/epics/src/governance/components/create-proposal-change-voting-method-form.tsx
  • packages/epics/src/governance/components/document-card.tsx
  • packages/epics/src/governance/components/issue-new-token-form.tsx
  • packages/epics/src/governance/components/membership-exit-form.tsx
  • packages/epics/src/governance/components/mint-tokens-to-space-treasury-form.tsx
  • packages/epics/src/governance/components/proposal-activate-spaces-data.tsx
  • packages/epics/src/governance/components/proposal-token-items.tsx
  • packages/epics/src/governance/components/space-to-space-membership-form.tsx
  • packages/epics/src/governance/hooks/use-proposal-notifications.ts
  • packages/epics/src/governance/hooks/use-space-token-requirements-by-address.ts
  • packages/epics/src/hooks/use-resubmit-proposal-data.ts
  • packages/epics/src/notifications/components/notification-centre-form.tsx
  • packages/epics/src/people/components/activate-spaces-form.tsx
  • packages/epics/src/people/components/button-profile.connected.tsx
  • packages/epics/src/people/components/button-signin-mobile.tsx
  • packages/epics/src/people/components/delegate-voting-section.tsx
  • packages/epics/src/people/components/delegated-member-selector.tsx
  • packages/epics/src/people/components/delegated-space-selector.tsx
  • packages/epics/src/people/components/member-card.tsx
  • packages/epics/src/people/components/people-purchase-hypha-tokens.tsx
  • packages/epics/src/people/components/signup-panel.tsx
  • packages/epics/src/people/components/space-member-card.tsx
  • packages/epics/src/people/components/space-with-number-of-months-array.tsx
  • packages/epics/src/people/components/space-with-number-of-months.tsx
  • packages/epics/src/proposals/components/form-voting.tsx
  • packages/epics/src/proposals/components/proposal-detail.tsx
  • packages/epics/src/spaces/components/create-space-form.tsx
  • packages/epics/src/spaces/components/entry-method-token-field.tsx
  • packages/epics/src/spaces/components/entry-method.tsx
  • packages/epics/src/spaces/components/explore-spaces.tsx
  • packages/epics/src/spaces/components/join-space.tsx
  • packages/epics/src/spaces/components/my-filtered-spaces.tsx
  • packages/epics/src/spaces/components/parent-space-selector.tsx
  • packages/epics/src/spaces/components/transparency-level.tsx
  • packages/epics/src/spaces/hooks/use-filter-spaces-list.ts
  • packages/epics/src/spaces/hooks/use-member-web3-space-ids.ts
  • packages/epics/src/spaces/hooks/use-spaces-discoverability-batch.ts
  • packages/epics/src/treasury/components/assets/asset-card.tsx
  • packages/epics/src/treasury/components/assets/assets-list.tsx
  • packages/epics/src/treasury/components/common/decay-settings.tsx
  • packages/epics/src/treasury/components/common/general-token-settings.tsx
  • packages/epics/src/treasury/components/common/token-max-supply-field.tsx
  • packages/epics/src/treasury/components/common/token-max-supply-type-field.tsx
  • packages/epics/src/treasury/components/common/token-price-field.tsx
  • packages/epics/src/treasury/components/common/transfer-whitelist-field-array.tsx
  • packages/epics/src/treasury/components/requests/transactions-list.tsx
  • packages/epics/src/treasury/components/requests/transfer-card.tsx
  • packages/epics/src/treasury/plugins/mint-tokens-to-space-treasury/plugin.tsx
  • packages/evm/package.json
  • packages/feature-flags/package.json
  • packages/i18n/package.json
  • packages/ui-utils/package.json
  • packages/ui-utils/src/formatSeconds.ts
  • packages/ui-utils/src/set-number-value.ts
  • packages/ui-utils/src/try-decode-uri-part.ts
  • packages/ui/package.json
  • packages/ui/src/button-nav-item.tsx
  • packages/ui/src/carousel.tsx
  • packages/ui/src/chips.tsx
  • packages/ui/src/combobox.tsx
  • packages/ui/src/date-picker.tsx
  • packages/ui/src/error-alert.tsx
  • packages/ui/src/form.tsx
  • packages/ui/src/slider.tsx
  • packages/ui/src/text-with-links.tsx
  • packages/ui/src/upload/add-attachment.tsx
  • packages/ui/src/upload/attachments-list.tsx
  • packages/ui/src/upload/lead-image.tsx

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/pnpm-build-errors-0d02
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

plitzenberger and others added 8 commits March 17, 2026 12:42
Adopt package-level ESLint flat config wiring to use the shared config package so lint runs consistently across workspaces. This also fixes ui and ui-utils warnings that were blocking monorepo lint under --max-warnings 0.

Made-with: Cursor
Tighten typing and remove unused symbols across core hooks and server utilities so package-level lint passes with --max-warnings 0. This also streamlines transfer parsing and error handling without changing runtime behavior.

Made-with: Cursor
Clean up unused symbols, improve type safety, and replace unsafe lint suppressions across agreements, governance, hooks, notifications, people, proposals, spaces, and treasury so epics lint passes with max warnings set to zero.

Made-with: Cursor
Apply focused lint-safe cleanups in app routes, UI pages, hooks, and API handlers by removing unused variables, tightening unknown/error handling, and fixing hook/ts-comment issues to keep web lint green.

Made-with: Cursor
- visible-spaces-list: convert null to undefined for useUserSpaceState spaceId
- layout: remove unused @ts-expect-error directive
- extract-revert-reason: add isHexData type guard and fix error.data typing
- decoders: use Abi type for decodeFunctionData, fix ProposalTx
- useProposalActions/useProposalDetails: fix readonly array and unknown assertions
- get-proposal-created-event/get-space-created-event: add Log[] type for parseEventLogs
- governance validation: add milestone undefined guard
- space queries: convert null to undefined for DB record mapping
- create-agreement-base-fields: use schemaCreateAgreementFiles for z.infer
- Image avatarUrl: add typeof string guards for Next.js Image src prop
- propose-contribution validation: add milestone undefined guard
- button-profile: ensure isErrorUser returns boolean
- delegate-voting-section: fix unknown error type for ReactNode
- member-card/space-member-card: add string guard for memberAddress
- date-picker: conditional render for single vs range Calendar mode
- slider: handle undefined from newValue[0]
- .env.template: add DEFAULT_DB_URL for build (storage-postgres invariant)

Co-authored-by: webguru-hypha <webguru-hypha@users.noreply.github.com>
@plitzenberger plitzenberger force-pushed the cursor/pnpm-build-errors-0d02 branch from 0b66fef to 89fd265 Compare March 17, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants