Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

@ravisingal
Copy link
Contributor

No description provided.

@ravisingal ravisingal requested a review from a team as a code owner May 14, 2024 07:20
@github-actions
Copy link

Test Results

366 tests  ±0   366 ✅ ±0   8s ⏱️ ±0s
 67 suites ±0     0 💤 ±0 
 67 files   ±0     0 ❌ ±0 

Results for commit b43b6e7. ± Comparison against base commit 77592de.

This pull request removes 17 and adds 2 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

scaleUp:
policy:
type: Pods
value: 2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravisingal In simple words, this scaleUp policy will add max 2 pods within any 60 sec (until it reaches maxReplicas) and scaleDown policy will remove min 1 pod within any 600 sec (until it reaches minReplicas) after looking at previous window of 600 seconds, right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants