ENGTAI-68310 : Adding logic and fixing order #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sukhamjot-Singh
requested review from
avinashkolluru,
kotharironak,
skjindal93 and
suresh-prakash
as code owners
| * IN" functionality by combining the $not and $in operators. | ||
| */ | ||
| @AllArgsConstructor | ||
| public class MongoStandardExprNotInRelationalFilterParser implements MongoRelationalFilterParser { |
There was a problem hiding this comment.
My bad on the naming suggestion earlier. Since we are special casing "NOT_IN", it is no longer a standard one.
Suggested change
| public class MongoStandardExprNotInRelationalFilterParser implements MongoRelationalFilterParser { | |
| public class MongoNotInExprRelationalFilterParser implements MongoRelationalFilterParser { |
I have added test for Mongo provider |
| * environment IDs. | ||
| */ | ||
| @ParameterizedTest | ||
| @ArgumentsSource(MongoProvider.class) |
There was a problem hiding this comment.
Anything we build in document-store needs to be compatible with Postgres too to avoid digressing them too much. Could you please sync. with the respective team to get this working on Postgres too? I believe that should be a smaller fix too.
Sukhamjot-Singh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There a was a bug when using NOT_IN in the array pipeline.