-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore(deps): Update go toolchain 1.24.5 and other deps #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
matthewmcneely
wants to merge
10
commits into
main
Choose a base branch
from
matthewmcneely/update-toolchain-1.24.5-and-other-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore(deps): Update go toolchain 1.24.5 and other deps #2216
matthewmcneely
wants to merge
10
commits into
main
from
matthewmcneely/update-toolchain-1.24.5-and-other-deps
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we want Helpful for local development
Was causing a race detection error on OSX
ce74bca
to
88d4f27
Compare
mangalaman93
requested changes
Aug 19, 2025
|
||
# Run this script from its directory, so that badgerpb4.proto is where it's expected to | ||
# be. | ||
# be. Only run this script if you've made changes to the API in badgerpb4.proto. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the harm in running it anyway?
require.NoError(t, sw.Write(buf), "sw.Write() failed") | ||
require.NoError(t, sw.Flush(), "sw.Flush() failed") | ||
|
||
// Single defer at the end to release the final buffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are two different buffers that we are trying to release. This does not seem right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the go toolchain and other deps.
Checklist
CHANGELOG.md
file describing and linking tothis PR