Skip to content

Conversation

matthewmcneely
Copy link
Member

Description

This PR upgrades the go toolchain and other deps.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to
    this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable

@matthewmcneely matthewmcneely force-pushed the matthewmcneely/update-toolchain-1.24.5-and-other-deps branch from ce74bca to 88d4f27 Compare August 2, 2025 13:50

# Run this script from its directory, so that badgerpb4.proto is where it's expected to
# be.
# be. Only run this script if you've made changes to the API in badgerpb4.proto.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the harm in running it anyway?

require.NoError(t, sw.Write(buf), "sw.Write() failed")
require.NoError(t, sw.Flush(), "sw.Flush() failed")

// Single defer at the end to release the final buffer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two different buffers that we are trying to release. This does not seem right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants