Skip to content

feat: Add order grouping support #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −4
Open

feat: Add order grouping support #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2469012
Support grouping in exchange.order
JoanLaRosa Feb 9, 2025
9744234
fix order_wires_to_order_action function
JoanLaRosa Feb 13, 2025
9846f0a
remove unnecessary grouping in order function
JoanLaRosa Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions hyperliquid/exchange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from hyperliquid.utils.signing import (
CancelByCloidRequest,
CancelRequest,
Grouping,
ModifyRequest,
OidOrCloid,
OrderRequest,
Expand Down Expand Up @@ -106,15 +107,20 @@ def order(
order["cloid"] = cloid
return self.bulk_orders([order], builder)

def bulk_orders(self, order_requests: List[OrderRequest], builder: Optional[BuilderInfo] = None) -> Any:
def bulk_orders(
self,
order_requests: List[OrderRequest],
builder: Optional[BuilderInfo] = None,
grouping: Grouping = "na",
) -> Any:
order_wires: List[OrderWire] = [
order_request_to_order_wire(order, self.info.name_to_asset(order["coin"])) for order in order_requests
]
timestamp = get_timestamp_ms()

if builder:
builder["b"] = builder["b"].lower()
order_action = order_wires_to_order_action(order_wires, builder)
order_action = order_wires_to_order_action(order_wires, builder, grouping)

signature = sign_l1_action(
self.wallet,
Expand Down
4 changes: 2 additions & 2 deletions hyperliquid/utils/signing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,11 +407,11 @@ def order_request_to_order_wire(order: OrderRequest, asset: int) -> OrderWire:
return order_wire


def order_wires_to_order_action(order_wires, builder=None):
def order_wires_to_order_action(order_wires, builder=None, grouping: Grouping="na"):
action = {
"type": "order",
"orders": order_wires,
"grouping": "na",
"grouping": grouping,
}
if builder:
action["builder"] = builder
Expand Down
Loading