Fix flaky test test_drop #885
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
requested review from
danbugs,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
ludfjig
added
kind/refactor
ludfjig
force-pushed
the
fix_test_drop
branch
2 times, most recently
from
539b58d to
1e52586
Compare
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
fix_test_drop
branch
from
1e52586 to
66d5c0d
Compare
ludfjig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was observed to be flaky, I believe due to race condition where other tests mmap allocate the same address (reused) after the memory is dropped, but before proocmaps are read. Fix by increasing memory size alot to prevent reuse of same address (hopefully). Also now runs on windows and no need to #[ignore]. If this doesn't fix it, we can try some other strategy or remove the test