Remove support for building PE files from hyperlight-guest-bin build.rs #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
marosset and
jprendes
as code owners
simongdavies
added
the
kind/enhancement
ludfjig
previously approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Looks reasonable, maybe @syntactically could have a look as she wrote the code
Signed-off-by: Simon Davies <[email protected]>
simongdavies
force-pushed
the
remove-pe-support-from-build.rs
branch
from
d16d57c to
1193045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the build process for the
hyperlight_guest_binby removing support for Windows-specific tools and configurations since we no longer support PE guests.