Take guestbinary by ref instead of value #560
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
requested review from
danbugs,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
from
af96a45 to
6698c2e
Compare
ludfjig
added
the
kind/enhancement
jprendes
reviewed
Jun 4, 2025
| @@ -132,7 +132,7 @@ impl UninitializedSandbox { | |||
| skip(guest_binary), | |||
| parent = Span::current() | |||
| )] | |||
| pub fn new(guest_binary: GuestBinary, cfg: Option<SandboxConfiguration>) -> Result<Self> { | |||
| pub fn new(guest_binary: &GuestBinary, cfg: Option<SandboxConfiguration>) -> Result<Self> { | |||
There was a problem hiding this comment.
suggestion: Take Borrow<GuestBinary>, then you can take GuestBinary or &GuestBinary. That would also help reduce the number of changes in this PR, as it would be backwards compatible.
Suggested change
| pub fn new(guest_binary: &GuestBinary, cfg: Option<SandboxConfiguration>) -> Result<Self> { | |
| pub fn new(guest_binary: impl Borrow<GuestBinary>, cfg: Option<SandboxConfiguration>) -> Result<Self> { | |
| let guest_binary = guest_binary.borrow(); |
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
from
6698c2e to
fc417d0
Compare
danbugs
approved these changes
Jun 4, 2025
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
from
fc417d0 to
453819f
Compare
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
from
453819f to
1b28b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #559
Making
Uninitialized::newtake aGuestBinaryby ref instead of value is more flexible, allowing reuse of the same guest binary across many different sandboxes. This PR allows passing either a ref or value, to be maximally flexible and not be a breaking change