Remove some dev-dependecies and cargo features to speed up compilation #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
requested review from
danbugs,
dblnz,
devigned,
jprendes,
marosset,
simongdavies and
syntactically
as code owners
ludfjig
force-pushed
the
minimize_dev_deps
branch
from
ac4c80c to
2929107
Compare
ludfjig
added
kind/enhancement
simongdavies
previously approved these changes
May 29, 2025
Contributor
simongdavies
left a comment
simongdavies
left a comment
There was a problem hiding this comment.
Did you test that the instructions at https://github.com/hyperlight-dev/hyperlight/blob/main/docs/hyperlight-metrics-logs-and-traces.md#using-otlp-exporter-and-jaeger still work?
dblnz
approved these changes
Jun 3, 2025
ludfjig
force-pushed
the
minimize_dev_deps
branch
2 times, most recently
from
dcf6f4f to
e30d48e
Compare
Contributor
Author
fixed
yes |
ludfjig
force-pushed
the
minimize_dev_deps
branch
from
e30d48e to
ff471dc
Compare
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
…hread::scope with std::thread::scope Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
minimize_dev_deps
branch
from
ff471dc to
bc3ccee
Compare
ludfjig
changed the title
jsturtevant
reviewed
Jul 2, 2025
jsturtevant
approved these changes
Jul 3, 2025
marosset
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrease the amount of crates we have to compile.
cargo testgoes from compiling 382 crates to 358.cargo buildgoes from 164 to 160.On my machine:
cargo buildgoes from 28.1s to 26.8scargo testgoes from 84.4s to 65.5sNote that the
builtcrate (behind default featurebuild-metadata) brings in roughly 60 crates and the build script takes roughly 20s on my machine due to bringing in libgit2-sys. Disabling this feature bringscargo builddown to only 98 crates, and cuts complication time by 60%. Should we makebuild-metadatafeature off-by-default?