[trace-dump] Fix MemFree writing to file for mem_profile feature
#1051
+16
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trace-dumputility tool expects only a pointer when a free operation is reported.The place where the
mem_tracefile is read can be checked at trace_dump/main.rs#L593 where you can see that forframe_id==3there is noamountread.When
mem_tracefeature is enabled for both host and guest, this works as follows:ptr, lento the host for the alloc/free which represent: the allocated/freed pointer, the length of the allocated memory<uuid>.tracefile the following info:time, trace_id, ptr, amount, stack. Trace ID represents the type of allocation.ptr, stackfor theFreevariant, hence the fix here.<uuid>.tracefile