Avoid build failure due to warning running docker build

Rush interpretted output to stderr from the docker build command as a
build warning. This failed the build pipeline.

Also:

- Update version of Rush and pnpm.
- Remove use of toolchain package since it has been unpublished from the
  npm registry.

Signed-off-by: Mark S. Lewis <[email protected]>

.github/workflows/release.yaml

@@ -4,7 +4,7 @@
 name: Release
 
 on:
-  create:
+  push:
     tags:
       - "v2.*"
   workflow_dispatch:

.github/workflows/schedule.yaml

@@ -11,5 +11,3 @@ on:
 jobs:
   test:
     uses: ./.github/workflows/test.yaml
-    with:
-      checkout-ref: ${{ matrix.checkout-ref }}

.github/workflows/test.yaml

@@ -5,11 +5,6 @@ name: Test
 
 on:
   workflow_call:
-    inputs:
-      checkout-ref:
-        default: ''
-        required: false
-        type: string
 
 jobs:
   setup:
@@ -20,8 +15,6 @@ jobs:
       BUILD_DATE: ${{ steps.builddata.outputs.BUILD_DATE }}
     steps:
       - uses: actions/checkout@v3
-        with:
-          ref: ${{ inputs.checkout-ref }}
       - uses: actions/setup-node@v3
         with:
           node-version: '18.x'
@@ -48,18 +41,12 @@ jobs:
 
   build:
     runs-on: ubuntu-20.04
-    strategy:
-      matrix:
-        node-version: [18.x]
 
     steps:
       - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
-          ref: ${{ inputs.checkout-ref }}
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
+          node-version: '18.x'
       - name: Install/Rebuild/UnitTest
         run: |
           set -xev
@@ -96,17 +83,11 @@ jobs:
   fvtest:
     runs-on: ubuntu-20.04
     needs: build
-    strategy:
-      matrix:
-        node-version: [18.x]
     steps:
       - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
-          ref: ${{ inputs.checkout-ref }}
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
+          node-version: '18.x'
 
       - uses: actions/download-artifact@v3
         with:
@@ -156,17 +137,11 @@ jobs:
   src_audit:
     runs-on: ubuntu-20.04
     needs: build
-    strategy:
-      matrix:
-        node-version: [18.x]
     steps:
       - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
-          ref: ${{ inputs.checkout-ref }}
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
+          node-version: '18.x'
       - uses: actions/download-artifact@v3
         with:
           name: node-tgzs

CONTRIBUTING.md

@@ -22,7 +22,7 @@ The following [Rush categories](https://rushjs.io/pages/maintainer/add_to_repo/)
 
 ### Pre-requisites
 
-* node v16.4.0 (npm v8.0.0) => recommend to use [nvm](https://github.com/nvm-sh/nvm)
+* node v18 => recommend to use [nvm](https://github.com/nvm-sh/nvm)
 * rush => `npm install -g @microsoft/rush`
 
 > Note that npm v6 has some bugs that mean adding new dependencies etc are not properly picked up. Longer term we should consider moving to yarn or pnpm. However in practice this isn't a serious problem and has been possible to be worked around by issuing `rm ./common/config/rush/npm-shrinkwrap.json` and then `rush update`
@@ -33,7 +33,7 @@ They also need to have the `nodeenv` image present - this is build as part of th
 
 ## Using the repo
 
-* Clone the repo, and ensure you are using node v12, and have rush installed
+* Clone the repo, and ensure you are using node v18, and have rush installed
 * `rush update` is needed to ensure everything is correctly linked and updated.
 * `rush edge-docker` will pull down and tag the very latest docker images for the peers, orderes etc to test against