-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPC WS options to specify password file for keystore and truststore #7970
Conversation
Signed-off-by: Bhanu Pulluri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just update the CHANGELOG
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
rpc-ws-ssl-keystore-type="none" | ||
rpc-ws-ssl-client-auth-enabled=false | ||
rpc-ws-ssl-truststore-file="none.pfx" | ||
rpc-ws-ssl-truststore-password="none.passwd" | ||
rpc-ws-ssl-truststore-password-file="none.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make sense to specify both password and password-file or should we only allow one or the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is handled by @CommandLine.ArgGroup(exclusive = true, multiplicity = "1")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's the intent using ArgGroup to make them exclusive but it doesn't seem to work when I tested. Right now , password takes precedence over password file if both are specified. I'll track this in a new issue
@pullurib please check if this failing test is related to your change
|
They pass when I sync my local branch and run the tests locally. I do see an error log though
Looks like that is expected by the tests |
PR Description
Fixed Issue(s)
#7931