dlog validator service: benchmark #1284 #1285
Open
+3,390
−1,869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
force-pushed
the
1284-dlog-validator-service-benchmark
branch
4 times, most recently
from
41d63af to
306516e
Compare
Signed-off-by: Angelo De Caro <[email protected]>
adecaro
force-pushed
the
1284-dlog-validator-service-benchmark
branch
from
61b9a21 to
314caa9
Compare
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
aaadir
reviewed
Dec 9, 2025
| "github.com/hyperledger-labs/fabric-token-sdk/token/core/zkatdlog/nogh/v1/issue/mock" | ||
| v1 "github.com/hyperledger-labs/fabric-token-sdk/token/core/zkatdlog/nogh/v1/setup" | ||
| "github.com/hyperledger-labs/fabric-token-sdk/token/core/zkatdlog/nogh/v1/token" | ||
| benchmark2 "github.com/hyperledger-labs/fabric-token-sdk/token/services/benchmark" |
Contributor
There was a problem hiding this comment.
there appears to be just one imported benachmark package left here - why isn't it just called "benchmark"?
aaadir
reviewed
Dec 9, 2025
Contributor
There was a problem hiding this comment.
why are these keys in the git? wouldn't it be better to create them on the fly as part of the setup of the tests/benchmarks? e.g., that would make the git more stable when the structure of these keys change for some reason.
aaadir
reviewed
Dec 9, 2025
Contributor
There was a problem hiding this comment.
what's the difference between the following?
token/core/zkatdlog/nogh/v1/transfer_test.go
token/core/zkatdlog/nogh/v1/transfer/transfer_test.go
aaadir
reviewed
Dec 9, 2025
|
|
||
| func TestValidator(t *testing.T) { | ||
| t.Run("Validator is called correctly with a non-anonymous issue action", func(t *testing.T) { | ||
| configurations, err := benchmark.NewSetupConfigurations("./../testdata", []uint64{testUseCase.Bits}, []math.CurveID{testUseCase.CurveID}) |
Contributor
There was a problem hiding this comment.
looks like the following 4 lines of code are repeated in many tests here. Consider using some common getter.
Signed-off-by: Angelo De Caro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: