Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(getStarted): Add info callout for send test message limitation #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(getStarted): Add info callout for send test message limitation #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/deploy-hyperlane.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,11 @@ To send a test message, run:
```bash
hyperlane send message --relay
```

:::info
Currently core self-relay only works **from Holesky** **to your custom chain**. When dispatch is successful, you should see that the message was self-relayed!
Copy link
Contributor Author

@Mo-Hussain Mo-Hussain Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ltyu - I was able to self relay from Sepolia, is it supposed to only be from Holesky?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was patched but its a bit hacky
https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/c2c5bb9bbcbb732f6697caa4f81bb94a69f523fb/typescript/cli/src/status/message.ts#L90

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but yes other origins should work now


Support in the CLI for other origin chains is being added; chains that are not supported will output `Error: No fallback hook config found`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a different error message, should we remove the specific error message from here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was fixed by @yorhodes. if this is no longer an issue, we can remove that specific error message. I believe relaying from custom chain to existing chain is still not possible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what error did you see @Mo-Hussain ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Only built 1 of 2 required modules raised here https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/70830ffb3e0739df0c2030f2e2a0fcdc61e55d5d/typescript/sdk/src/ism/metadata/aggregation.ts#L30

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think we should callout that self relay from custom chain to aw managed chain will not work

Copy link
Member

@yorhodes yorhodes Aug 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self relay from custom chain to aw managed chain will not work

this will work if there is a supported ISM configured on the aw managed chain

:::


:::note
Expand Down