Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate warp addresses #513

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mshojaei-txfusion
Copy link
Contributor

Description

Remove -addresses.yaml files for warp deployments since addresses are now maintained in config files. This change:

  1. Removes warp-specific address YAML files
  2. Removes warp address file generation functionality from registry
  3. Updates registry tests to remove warp address file validation checks

This cleanup consolidates warp deployment addresses to a single location in the config files.

Related issues

hyperlane-xyz/hyperlane-monorepo#5245

Backward compatibility

Yes - This is a cleanup of redundant warp address files. All warp deployment addresses remain available in the config files.

Testing

  • Verified that all warp addresses previously in YAML files exist in corresponding config files
  • Updated and ran registry tests to confirm functionality without warp address files
  • Validated that CLI and other tooling continue to work with warp addresses from config files

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 5fd3455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperlane-xyz/registry Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that we'll need to update the CLI with this to avoid checking it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants