Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cli): warp commands e2e tests #5121

Merged
merged 41 commits into from
Jan 22, 2025
Merged

test(cli): warp commands e2e tests #5121

merged 41 commits into from
Jan 22, 2025

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Jan 7, 2025

Description

This PR tries to e2e test multiple use cases with warp commands to ensure that future changes that might break or change the commands' behavior are detected early.

Drive-by changes

  • fixes skipConfirmation propagation in signer strategy code
  • move the warp e2e tests into the test/warp folder

Related issues

Backward compatibility

  • YES

Testing

  • Manual
  • E2E

xeno097 added 25 commits December 26, 2024 15:51
@xeno097
refactor(cli/test): moved core e2e tests to the core folder
d0ae4b1
@xeno097
test(cli/test): added e2e tests for the core check command
edee675
@xeno097
test(cli/test): added core init cli tests
23b4cc9
@xeno097
refactor(cli/test): updated the warp init tests to make it easier to …
325f71d 
…test prompts
@xeno097
refactor(cli/test): updated the core init tests to use the handleProm…
dd9b0ae 
…pts func
@xeno097
test(cli/test): started adding more tests to core dpeloy
7f3ccb1
@xeno097
refactor(cli): removed the skip-confirmation flag from the core deplo…
1328345 
…y command
@xeno097
tests(cli): added an HYP_KEY test for the core deploy e2e tests
d0a18b3
@xeno097
test(cli): added an HYP_KEY test to the core init e2e test
284b31a
@xeno097
test(cli): updated core init tests
f9c5dfd
@xeno097
refactor(cli/tests): defined the SETUP_CHAIN_SIGNERS_MANUALLY_STEPS u…
3e509d4 
…tils
@xeno097
chore: added new core e2e tests to the ci
036598f
@xeno097
fix(cli/test): fixed core check test
32997ee
@xeno097
refactor(cli): moved warp commands e2e test to the warp folder
79af52f
@xeno097
test(cli): started working on the warp check e2e tests
a2fcc8b
@xeno097
feat(cli): started working on the warp send e2e tests
58afc33
@xeno097
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
1e3e570 
…to xeno/warp-commands-e2e-tests
@xeno097
test(cli): implemented warp send e2e test
eba2b2d
@xeno097
test(cli/test): added more e2e test fro the warp deploy commmand with…
084f3c9 
… different flag configs
@xeno097
fix(cli): fixed skipConfirmation flag propagation in signer middleware
0a5ab5e
@xeno097
test(cli/test): implemented more tests for the warp read command with…
d990b43 
… different flag combinations
@xeno097
test(cli/test): added more tests for the warp check command with diff…
49fafe7 
…erent flags combinations
@xeno097
test(cli/test): minor refactor on the warp command utility
639e7bc
@xeno097
test(cli/test): deduped warp deploy file path var
a0af428
@xeno097
test(cli): minor refactor on test assertion for warp check
75a7437
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1a6eaeb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xeno097 xeno097 requested a review from paulbalaji January 9, 2025 16:46
jmrossy
jmrossy reviewed Jan 11, 2025
View reviewed changes
wbtc-ethereum-form.yaml Outdated Show resolved Hide resolved
typescript/cli/src/tests/commands/helpers.ts Outdated Show resolved Hide resolved
@xeno097 xeno097 requested a review from jmrossy January 14, 2025 20:27
yorhodes
yorhodes reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new test coverage is great but I think we can significantly dedupe some of the test scaffolding and make the diff here much smaller/more extensible to new token types etc

typescript/cli/src/tests/warp/warp-check.e2e-test.ts Outdated Show resolved Hide resolved
typescript/cli/src/tests/warp/warp-deploy.e2e-test.ts Outdated Show resolved Hide resolved
typescript/cli/src/tests/warp/warp-deploy.e2e-test.ts Outdated Show resolved Hide resolved
@xeno097 xeno097 requested a review from yorhodes January 21, 2025 14:44
yorhodes
yorhodes approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still definitely feel like lots of opportunity to dedupe but lets just keep in mind extensibility of tests like this going forward

@xeno097 xeno097 added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@paulbalaji paulbalaji added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@paulbalaji paulbalaji enabled auto-merge January 22, 2025 11:41
@paulbalaji paulbalaji added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 9e38617 Jan 22, 2025
42 checks passed
@paulbalaji paulbalaji deleted the xeno/warp-commands-e2e-tests branch January 22, 2025 15:28
@paulbalaji paulbalaji mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorhodes yorhodes yorhodes approved these changes

@ltyu ltyu Awaiting requested review from ltyu ltyu is a code owner

@paulbalaji paulbalaji Awaiting requested review from paulbalaji paulbalaji is a code owner

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xeno097 @jmrossy @yorhodes @paulbalaji