-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually tested infra secrets + CLI http registry #5120
base: main
Are you sure you want to change the base?
Conversation
|
@@ -92,7 +92,7 @@ export function mergeJson<T extends Record<string, any>>( | |||
} | |||
|
|||
export function readYaml<T>(filepath: string): T { | |||
return yamlParse(readFileAtPath(filepath)) as T; | |||
return yamlParse(readFileAtPath(filepath), { maxAliasCount: -1 }) as T; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will pull this into an atomic PR
@@ -52,6 +52,7 @@ | |||
"undici": "^5.11", | |||
"@trivago/prettier-plugin-sort-imports/@babel/parser": "^7.22.7", | |||
"@typechain/ethers-v5": "11.1.2", | |||
"typechain@npm:^8.0.0": "patch:typechain@npm%3A8.3.2#~/.yarn/patches/typechain-npm-8.3.2-b02e27439e.patch" | |||
"typechain@npm:^8.0.0": "patch:typechain@npm%3A8.3.2#~/.yarn/patches/typechain-npm-8.3.2-b02e27439e.patch", | |||
"@hyperlane-xyz/registry": "portal:/Users/yorhodes/hyperlane/registry" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will need to fix this
actually yarn link
worked pretty well for me here
const registry = | ||
environment === 'mainnet3' | ||
? await getMainnet3Registry() | ||
: await getTestnet4Registry(); | ||
|
||
const server = new HttpServer(registry); | ||
await server.start(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooooh I see, I like this a lot
Description
Serves HTTP registry from infra secrets with
$ yarn tsx scripts/http-registry.ts -e mainnet3
.Consumes HTTP registry from CLI with
$ yarn hyperlane ... --registry http://localhost:3000
Drive-by changes
Related issues
Backward compatibility
Testing
Manual