Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually tested infra secrets + CLI http registry #5120

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Jan 7, 2025

Description

Serves HTTP registry from infra secrets with $ yarn tsx scripts/http-registry.ts -e mainnet3.

Consumes HTTP registry from CLI with $ yarn hyperlane ... --registry http://localhost:3000

Drive-by changes

Related issues

Backward compatibility

Testing

Manual

Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 8f81f51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -92,7 +92,7 @@ export function mergeJson<T extends Record<string, any>>(
}

export function readYaml<T>(filepath: string): T {
return yamlParse(readFileAtPath(filepath)) as T;
return yamlParse(readFileAtPath(filepath), { maxAliasCount: -1 }) as T;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will pull this into an atomic PR

@@ -52,6 +52,7 @@
"undici": "^5.11",
"@trivago/prettier-plugin-sort-imports/@babel/parser": "^7.22.7",
"@typechain/ethers-v5": "11.1.2",
"typechain@npm:^8.0.0": "patch:typechain@npm%3A8.3.2#~/.yarn/patches/typechain-npm-8.3.2-b02e27439e.patch"
"typechain@npm:^8.0.0": "patch:typechain@npm%3A8.3.2#~/.yarn/patches/typechain-npm-8.3.2-b02e27439e.patch",
"@hyperlane-xyz/registry": "portal:/Users/yorhodes/hyperlane/registry"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to fix this
actually yarn link worked pretty well for me here

Comment on lines +11 to +17
const registry =
environment === 'mainnet3'
? await getMainnet3Registry()
: await getTestnet4Registry();

const server = new HttpServer(registry);
await server.start();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooooh I see, I like this a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants