Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents/sealevel): handle non configured igp account payments #5075

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
+330 −24
Draft

fix(agents/sealevel): handle non configured igp account payments #5075

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
48c9f6d
zero out non matching igp pubkey
aroralanuk Dec 26, 2024
04bcac4
inter
aroralanuk Dec 27, 2024
181daa6
add pay for gas salt
aroralanuk Dec 30, 2024
682e87f
account-salt
aroralanuk Dec 30, 2024
3ecddf7
print igpa
aroralanuk Dec 31, 2024
acc94ba
rm extra pay-for-gas
aroralanuk Dec 31, 2024
e5d82bb
add gas oracle
aroralanuk Dec 31, 2024
02ae504
update skipped message
aroralanuk Jan 1, 2025
905376a
10msgs
aroralanuk Jan 1, 2025
d174fd3
fmt
aroralanuk Jan 1, 2025
d0ba59b
revert non paying tx
aroralanuk Jan 2, 2025
f19ac16
rm sealevel
aroralanuk Jan 2, 2025
3e7e919
igp artifact path salt
aroralanuk Jan 2, 2025
ef17f91
enable sealevel
aroralanuk Jan 2, 2025
5cc9759
add scraper back
aroralanuk Jan 2, 2025
b46f993
rm warp-init
aroralanuk Jan 2, 2025
abff1f1
reorder by non matching first
aroralanuk Jan 2, 2025
940488b
reorder
aroralanuk Jan 3, 2025
3a8c10a
revert invariant
aroralanuk Jan 3, 2025
5fe7ad8
rm comma
aroralanuk Jan 4, 2025
04d321c
set igp config
aroralanuk Jan 7, 2025
f884bd0
change logs
aroralanuk Jan 7, 2025
d510711
set for aggregation as default
aroralanuk Jan 7, 2025
2ba224b
index out of range
aroralanuk Jan 7, 2025
aee95b3
add parsing check
aroralanuk Jan 7, 2025
2c05b12
err instead of panic
aroralanuk Jan 8, 2025
0fdde68
cleanup
aroralanuk Jan 8, 2025
7f16ff0
Merge branch 'kunal/reenble-igp-enforcement' into kunal/index-other-igps
aroralanuk Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion rust/main/chains/hyperlane-sealevel/src/interchain_gas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,17 @@ impl Indexer<InterchainGasPayment> for SealevelInterchainGasPaymasterIndexer {
if igp_account_filter == sealevel_payment.igp_account_pubkey {
payments.push((sealevel_payment.payment, sealevel_payment.log_meta));
} else {
tracing::debug!(sealevel_payment=?sealevel_payment, igp_account_filter=?igp_account_filter, "Found interchain gas payment for a different IGP account, skipping");
tracing::debug!(sealevel_payment=?sealevel_payment, igp_account_filter=?igp_account_filter, "Found interchain gas payment for a different IGP account, neutralizing payment");

let non_matching_payment = InterchainGasPayment {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting a little hard to read, could we change the logic around here starting with line 249 to be something like:

if let Ok(mut sealevel_payment) = self.get_payment_with_sequence(nonce.into()).await {
  // Comment explaining why we do this
  if sealevel_payment.igp_account_pubkey != self.igp.igp_account {
    sealevel_payment.gas_amount = U256::zero();
    sealevel_payment.payment = U256::zero();
  }
  payments.push((sealevel_payment.payment, sealevel_payment.log_meta));
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

gas_amount: U256::from(0),
payment: U256::from(0),
..*sealevel_payment.payment.inner()
};
payments.push((
Indexed::new(non_matching_payment).with_sequence(nonce.into()),
sealevel_payment.log_meta,
));
}
}
}
Expand Down
Loading