fix: use implementation instead of admin slot for isProxy #5034
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b50d766 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5034 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
yorhodes
changed the title
paulbalaji
approved these changes
Dec 18, 2024
jmrossy
approved these changes
Dec 18, 2024
| const admin = await proxyAdmin(provider, proxy); | ||
| return !eqAddress(admin, ethers.constants.AddressZero); | ||
| const implementation = await proxyImplementation(provider, proxy); | ||
| return !eqAddress(implementation, ethers.constants.AddressZero); |
There was a problem hiding this comment.
I wonder if !isZeroishAddress here would be more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Admin slot is optional as per https://eips.ethereum.org/EIPS/eip-1967
This PR uses the implementation slot for determining whether the contract is a (1967) proxy.
Backward compatibility
Yes
Testing
None