fix(ethers-core): more accurate priority fee defaults#35
Merged
daniel-savu merged 8 commits intohyperlanefrom May 20, 2025
Merged
fix(ethers-core): more accurate priority fee defaults#35daniel-savu merged 8 commits intohyperlanefrom
daniel-savu merged 8 commits intohyperlanefrom
Conversation
|
looks good to me — I like the |
aroralanuk
commented
May 13, 2025
daniel-savu
reviewed
May 15, 2025
daniel-savu
approved these changes
May 19, 2025
github-merge-queue Bot
pushed a commit
to hyperlane-xyz/hyperlane-monorepo
that referenced
this pull request
May 21, 2025
### Description Applies changes from hyperlane-xyz/ethers-rs#35 - tested on Base and we now pay 80x less
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@christianangelopoulos spotted us overpaying priority fees on low-cost chains because of the default minimum of 0.1 gwei.
Looking deeper into this, there's some hardcoded/unnecessary logic that doesn't suit our needs well for transaction submission on EVM chains.
Solution
Idea is to make it estimate closer to that in alloy/metamask:
Tests
Unit
Note: Failing tests are etherscan API-related, not relevant for this PR.