Skip to content

fix interface, allow react 17, add onCurrentSlideChanged #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"test": "jest"
},
"peerDependencies": {
"react": "^16.8.6"
"react": "^16.8.6 || ^17.0.0"
},
"husky": {
"hooks": {
Expand Down
12 changes: 10 additions & 2 deletions src/Carousel.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from "react";
import React, { useEffect } from "react";
import useTouch from "./useTouch";
import useSlides from "./useSlides";
import useNavigation from "./useNavigation";
Expand All @@ -25,6 +25,7 @@ export interface CarouselProps {
transitionDuration?: number;
centerCurrentSlide?: boolean;
render?: (props: RenderProps) => React.ReactElement;
onCurrentSlideChanged?: (currentSlide: number) => void;
}

export type RefInstance = Pick<RenderProps, "next" | "previous" | "goToStep">
Expand All @@ -36,7 +37,8 @@ export default React.forwardRef<unknown, React.PropsWithChildren<CarouselProps>>
infinite = true,
transitionDuration = 300,
centerCurrentSlide = false,
render = ({ slides }: RenderProps) => slides
render = ({ slides }: RenderProps) => slides,
onCurrentSlideChanged,
},
ref
) => {
Expand All @@ -54,6 +56,12 @@ export default React.forwardRef<unknown, React.PropsWithChildren<CarouselProps>>

const { previous, next, goToStep, currentIndex } = navigation;

useEffect(() => {
if (typeof onCurrentSlideChanged === 'function') {
onCurrentSlideChanged(currentIndex)
}
},[currentIndex])

React.useImperativeHandle<unknown, RefInstance>(
ref,
() => ({
Expand Down
18 changes: 13 additions & 5 deletions src/VerticalCarousel.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from "react";
import React, { useEffect } from "react";
import useSlides from "./useSlides";
import useItemSize from "./useItemSize";
import useNavigation from "./useNavigation";
Expand All @@ -19,10 +19,11 @@ export interface RenderProps {

export interface VerticalCarouselProps {
children: React.ReactElement;
slidesToShow: number;
infinite: boolean;
transitionDuration: number;
render: (props: RenderProps) => React.ReactElement;
slidesToShow?: number;
infinite?: boolean;
transitionDuration?: number;
render?: (props: RenderProps) => React.ReactElement;
onCurrentSlideChanged?: (currentSlide: number) => void;
}

export default React.forwardRef<
Expand All @@ -36,6 +37,7 @@ export default React.forwardRef<
infinite = true,
transitionDuration = 300,
render = ({ slides }: RenderProps) => slides,
onCurrentSlideChanged,
},
ref: () => void
) => {
Expand All @@ -53,6 +55,12 @@ export default React.forwardRef<

const { previous, next, goToStep, currentIndex } = navigation;

useEffect(() => {
if (typeof onCurrentSlideChanged === 'function') {
onCurrentSlideChanged(currentIndex)
}
},[currentIndex])

React.useImperativeHandle(
ref,
() => ({
Expand Down