Skip to content

fix authority normalization #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdesrosiers merged 3 commits into from
Feb 23, 2026
Merged

fix authority normalization #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0556053
fix authority normalization
srivastava-diya Feb 20, 2026
5ab60c5
add normalize userinfo test case
srivastava-diya Feb 20, 2026
e771a3e
add test to resolveTests array
srivastava-diya Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ const resolveReference = (strategy) => (reference, base) => {

if (resolvedComponents.authority === undefined) {
resolvedComponents.authority = baseComponents.authority;
resolvedComponents.userinfo = baseComponents.userinfo;
resolvedComponents.host = baseComponents.host;
resolvedComponents.port = baseComponents.port;

if (resolvedComponents.path === "") {
resolvedComponents.path = baseComponents.path;
Expand Down Expand Up @@ -165,7 +168,10 @@ const getSegment = (path) => {
/** @type (strategy: Strategy, components: API.IdentifierComponents) => string */
const composeIdentifier = (strategy, components) => {
let resolved = components.scheme.toLowerCase() + ":";
resolved += components.authority === undefined ? "" : "//" + components.authority.toLowerCase();
resolved += components.authority === undefined ? "" : "//"
+ (components.userinfo === undefined ? "" : components.userinfo + "@")
+ components.host.toLowerCase()
+ (components.port === undefined ? "" : ":" + components.port);
resolved += strategy.normalizePath(components.path);
resolved += components.query === undefined ? "" : "?" + strategy.normalizeQuery(components.query);
resolved += components.fragment === undefined ? "" : "#" + strategy.normalizeFragment(components.fragment);
Expand Down
3 changes: 2 additions & 1 deletion lib/resolve-reference.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ const resolveTests = [
["http://example.com/b%2Fc/d/e", "", "http://example.com/b%2Fc/d/e"], // Necessary encoding segment
["http://example.com/b%2fc/d/e", "", "http://example.com/b%2Fc/d/e"], // Case normalization of encoding segment
["http://example.com/b?c%2Fd%3Fe", "", "http://example.com/b?c/d?e"], // Unnecessary encoding query
["http://example.com/b", "#c%2Fd%3Fe", "http://example.com/b#c/d?e"] // Unnecessary encoding fragment
["http://example.com/b", "#c%2Fd%3Fe", "http://example.com/b#c/d?e"], // Unnecessary encoding fragment
["Https://JDesrosiers@Example.com", "", "https://JDesrosiers@example.com"] // Case normalization of authority
];

describe("resolveReference", () => {
Expand Down