feat(util): introduce channel::Sender::try_send()
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr hyperium#140 introduced a new channel-backed body. this body provides a new equivalent to the defunct `hyper::Body::channel()` interface that was exposed in hyper 0.14, and removed in the 1.0 major release. the previous `Sender` type also included a useful method, `try_send_data()`, which allows a thread to _synchronously_ attempt to send data _outside_ of an asynchronous context. <https://docs.rs/hyper/0.14.31/hyper/body/struct.Sender.html#method.try_send_data> this commit introduces a loosely equivalent `Sender::try_send()` method to provide users of `http-body-util` with a means to send `Frame<T>` values outside of an asynchronous context, without potentially scheduling the caller to be woken later or yielding should the channel be full. this function accepts a `Frame<D>` rather than a chunk of data, to fit in with the shift towards frame-oriented interfaces in `http-body` and `http-body-util`. Signed-off-by: katelyn martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr #140 introduced a new channel-backed body. this body provides an equivalent to the defunct
hyper::Body::channel()interface that was exposed in hyper 0.14, and removed in the 1.0 major release.the previous
Sendertype also included a useful method,try_send_data(), which allows a thread to synchronously attempt to send data outside of an asynchronous context.https://docs.rs/hyper/0.14.31/hyper/body/struct.Sender.html#method.try_send_data
this commit introduces a loosely equivalent
Sender::try_send()method to provide users ofhttp-body-utilwith a means to sendFrame<T>values outside of an asynchronous context, without potentially scheduling the caller to be woken later or yielding should the channel be full.this function accepts a
Frame<D>rather than a chunk of data, to fit in with the shift towards frame-oriented interfaces inhttp-bodyandhttp-body-util.