fix!: resolve hyper error and bubble rejected non-handled exceptions. #12 #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12
Closes #9
I'm really sorry for the large PR. Most of the diff is utils and tests and lock files. I added a bunch of tests to ensure mappings from ES errors to hyper errors were correct. I can sit down on a call and walk through the changes if that helps.
various bug fixes and error mappings:
_id
field on index mappings and documents. So we map_id
to a__movedUnderscoreId63__
field internally for mappings, documents, and queries, then back to an_id
field when retrieving documents.I've added a task to the gitpod config to automatically spin up opensearch.
BREAKING CHANGE - caught exceptions are resolved, not rejected, as hyper
errors
The only time a method on the adapter should return a rejected promise
is in the case of an unhandled exception.
Aligns with discussion detailed in:
https://github.com/hyper63/journal/blob/master/design-docs/003-errors.md