-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update msys2.md #128
Update msys2.md #128
Conversation
😊 |
Did you build locally before submitting this pr? |
It seems that you also need to take a look at the blank lines. Some are redundant, and some require it. |
It's been a month, any update? @Baiyanghebaiyang |
Thank you very much for your reminder! I try it again.
|
The CI failed, and you didn't make any changes on the errors. |
I'm not quite sure where the problem lies. However, I've submitted it again. If there's no problem, thank you for your reminder.If there are still problems, I hope you can explain them more clearly. Thank you. |
You should not make direct modifications to |
Thank you for your patient guidance. I've submitted it again. Thank you very much! |
@tttturtle-russ CI is happy, you guys could take a look this version. |
sure thing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the content looks good, but you may need to leave at least one blank line between paragraphs to make sure the doc is rendered correctly. double check the output doc before submitting(current output is messed up).
btw, make your change directly in this pr rather than reopening a new one. I will take care of the commit history |
This is strange. I remember I had already added blank lines between the paragraphs yesterday. |
actually, you remove all the blank lines in 48335ff. |
Already compleleted,hope that I can join you!