Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msys2.md #128

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Conversation

Baiyanghebaiyang
Copy link
Contributor

Already compleleted,hope that I can join you!

@Baiyanghebaiyang
Copy link
Contributor Author

😊

@tttturtle-russ
Copy link
Member

Did you build locally before submitting this pr?

@tttturtle-russ tttturtle-russ linked an issue Nov 29, 2024 that may be closed by this pull request
@M0rtzz
Copy link
Member

M0rtzz commented Nov 29, 2024

It seems that you also need to take a look at the blank lines. Some are redundant, and some require it.

@tttturtle-russ
Copy link
Member

It's been a month, any update? @Baiyanghebaiyang

@Baiyanghebaiyang
Copy link
Contributor Author

Baiyanghebaiyang commented Jan 5, 2025 via email

@tttturtle-russ
Copy link
Member

The CI failed, and you didn't make any changes on the errors.

@Baiyanghebaiyang
Copy link
Contributor Author

I'm not quite sure where the problem lies. However, I've submitted it again. If there's no problem, thank you for your reminder.If there are still problems, I hope you can explain them more clearly. Thank you.

@M0rtzz
Copy link
Member

M0rtzz commented Jan 7, 2025

@Baiyanghebaiyang

You should not make direct modifications to docs/msys2.md. Instead, create a new msys2.md file in i18n/en/docusaurus-plugin-content-docs/current/ and write the content there.

@Baiyanghebaiyang
Copy link
Contributor Author

@Baiyanghebaiyang

You should not make direct modifications to docs/msys2.md. Instead, create a new msys2.md file in i18n/en/docusaurus-plugin-content-docs/current/ and write the content there.

Thank you for your patient guidance. I've submitted it again. Thank you very much!

@mudongliang
Copy link
Member

@tttturtle-russ CI is happy, you guys could take a look this version.

@tttturtle-russ
Copy link
Member

sure thing

Copy link
Member

@tttturtle-russ tttturtle-russ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content looks good, but you may need to leave at least one blank line between paragraphs to make sure the doc is rendered correctly. double check the output doc before submitting(current output is messed up).

i18n/en/docusaurus-plugin-content-docs/current/msys2.md Outdated Show resolved Hide resolved
@tttturtle-russ
Copy link
Member

btw, make your change directly in this pr rather than reopening a new one. I will take care of the commit history

@M0rtzz
Copy link
Member

M0rtzz commented Jan 9, 2025

the content looks good, but you may need to leave at least one blank line between paragraphs to make sure the doc is rendered correctly. double check the output doc before submitting(current output is messed up).

new commit

This is strange. I remember I had already added blank lines between the paragraphs yesterday.

@tttturtle-russ
Copy link
Member

actually, you remove all the blank lines in 48335ff.

@tttturtle-russ tttturtle-russ merged commit d571f02 into hust-open-atom-club:master Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

将 msys2.md 翻译为英文
4 participants